chrome/browser/extensions/api/omnibox/omnibox_api.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/api/record/record_api_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

index 16d0a09072fa0e69507ca3ffcaf879e6c7e243cd..29f3ae8edf4c27bb94cc9e811e9fb30a64be818a 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

@@ -179,7 +179,7 @@ bool ExtensionOmniboxSuggestion::Populate(const base::DictionaryValue& value,

return false;

}

for (size_t i = 0; i < styles->GetSize(); ++i) {

- base::DictionaryValue* style = NULL;

+ const base::DictionaryValue* style = NULL;

int offset, type;

if (!styles->GetDictionary(i, &style))

return false;

@@ -206,7 +206,7 @@ bool ExtensionOmniboxSuggestion::ReadStylesFromValue(

styles.resize(description.length()); // sets all styles to 0

for (size_t i = 0; i < styles_value.GetSize(); ++i) {

- DictionaryValue* style;

+ const DictionaryValue* style;

std::string type;

int offset;

int length;