chrome/browser/extensions/api/alarms/alarm_manager.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarm_manager.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/alarms/alarm_manager.cc

diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.cc b/chrome/browser/extensions/api/alarms/alarm_manager.cc

index fedb30fc1c1aa42034c6097fc966ce7ceb4534e6..cf7257689298b6de441aa91ec6d4eb4b86d75b30 100644

--- a/chrome/browser/extensions/api/alarms/alarm_manager.cc

+++ b/chrome/browser/extensions/api/alarms/alarm_manager.cc

@@ -59,11 +59,11 @@ base::TimeDelta TimeDeltaFromDelay(double delay_in_minutes) {

std::vector<Alarm> AlarmsFromValue(const base::ListValue* list) {

std::vector<Alarm> alarms;

for (size_t i = 0; i < list->GetSize(); ++i) {

- base::DictionaryValue* alarm_dict = NULL;

+ const base::DictionaryValue* alarm_dict = NULL;

Alarm alarm;

if (list->GetDictionary(i, &alarm_dict) &&

api::alarms::Alarm::Populate(*alarm_dict, alarm.js_alarm.get())) {

- base::Value* time_value = NULL;

+ const base::Value* time_value = NULL;

if (alarm_dict->Get(kAlarmGranularity, &time_value))

base::GetValueAsTimeDelta(*time_value, &alarm.granularity);

alarms.push_back(alarm);