Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/chromeos/gdata/gdata_contacts_service.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: David's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_contacts_service.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_contacts_service.cc b/chrome/browser/chromeos/gdata/gdata_contacts_service.cc
index b6657dad32cb73945358d82361bb1e0ab8eefe5a..16f49ad4ff536ad77199447c6f3191342153086a 100644
--- a/chrome/browser/chromeos/gdata/gdata_contacts_service.cc
+++ b/chrome/browser/chromeos/gdata/gdata_contacts_service.cc
@@ -180,7 +180,7 @@ std::string GetPhotoUrl(const DictionaryValue& dict) {
return std::string();
for (size_t i = 0; i < link_list->GetSize(); ++i) {
- DictionaryValue* link_dict = NULL;
+ const DictionaryValue* link_dict = NULL;
if (!link_list->GetDictionary(i, &link_dict))
continue;
@@ -237,7 +237,7 @@ bool FillContactFromDictionary(const base::DictionaryValue& dict,
const ListValue* email_list = NULL;
if (dict.GetList(kEmailField, &email_list)) {
for (size_t i = 0; i < email_list->GetSize(); ++i) {
- DictionaryValue* email_dict = NULL;
+ const DictionaryValue* email_dict = NULL;
if (!email_list->GetDictionary(i, &email_dict))
return false;
@@ -252,7 +252,7 @@ bool FillContactFromDictionary(const base::DictionaryValue& dict,
const ListValue* phone_list = NULL;
if (dict.GetList(kPhoneField, &phone_list)) {
for (size_t i = 0; i < phone_list->GetSize(); ++i) {
- DictionaryValue* phone_dict = NULL;
+ const DictionaryValue* phone_dict = NULL;
if (!phone_list->GetDictionary(i, &phone_dict))
return false;
@@ -267,7 +267,7 @@ bool FillContactFromDictionary(const base::DictionaryValue& dict,
const ListValue* address_list = NULL;
if (dict.GetList(kPostalAddressField, &address_list)) {
for (size_t i = 0; i < address_list->GetSize(); ++i) {
- DictionaryValue* address_dict = NULL;
+ const DictionaryValue* address_dict = NULL;
if (!address_list->GetDictionary(i, &address_dict))
return false;
@@ -285,7 +285,7 @@ bool FillContactFromDictionary(const base::DictionaryValue& dict,
const ListValue* im_list = NULL;
if (dict.GetList(kInstantMessagingField, &im_list)) {
for (size_t i = 0; i < im_list->GetSize(); ++i) {
- DictionaryValue* im_dict = NULL;
+ const DictionaryValue* im_dict = NULL;
if (!im_list->GetDictionary(i, &im_dict))
return false;
@@ -404,7 +404,7 @@ class GDataContactsService::DownloadContactsRequest
LOG(WARNING) << "Category list missing";
return false;
}
- DictionaryValue* category_dict = NULL;
+ const DictionaryValue* category_dict = NULL;
if (!category_list->GetSize() == 1 ||
!category_list->GetDictionary(0, &category_dict)) {
LOG(WARNING) << "Unable to get dictionary from category list of size "
« no previous file with comments | « chrome/browser/chromeos/cros/sms_watcher.cc ('k') | chrome/browser/custom_handlers/protocol_handler_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698