chrome/browser/chromeos/cros/onc_network_parser.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/onc_network_parser.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/cros/onc_network_parser.cc

diff --git a/chrome/browser/chromeos/cros/onc_network_parser.cc b/chrome/browser/chromeos/cros/onc_network_parser.cc

index 86376d6bb89194b9255293523e0d21ae8fea2650..26d722a7da27fb8608871911c5114099aad437f9 100644

--- a/chrome/browser/chromeos/cros/onc_network_parser.cc

+++ b/chrome/browser/chromeos/cros/onc_network_parser.cc

@@ -1941,7 +1941,7 @@ bool OncVirtualNetworkParser::ParseOpenVPNValue(OncNetworkParser* parser,

// today. So extract the first.

const base::ListValue* value_list = NULL;

value.GetAsList(&value_list);

- base::Value* first_item = NULL;

+ const base::Value* first_item = NULL;

if (!value_list->Get(0, &first_item) ||

!first_item->IsType(base::Value::TYPE_STRING)) {

VLOG(1) << "RemoteCertKU must be non-empty list of strings";

« no previous file with comments | « chrome/browser/chromeos/cros/cros_network_functions.cc ('k') | chrome/browser/chromeos/cros/sms_watcher.cc » ('j') | no next file with comments »