base/json/json_writer.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_writer.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_writer.cc

diff --git a/base/json/json_writer.cc b/base/json/json_writer.cc

index 9ca481301fe15da7e210fc60d7b2ede2c7aa60e7..e8cf9ac861b606fcc1e0e4985a590c180459d112 100644

--- a/base/json/json_writer.cc

+++ b/base/json/json_writer.cc

@@ -139,7 +139,7 @@ void JSONWriter::BuildJSONString(const Value* const node, int depth) {

const ListValue* list = static_cast<const ListValue*>(node);

for (size_t i = 0; i < list->GetSize(); ++i) {

- Value* value = NULL;

+ const Value* value = NULL;

bool result = list->Get(i, &value);

DCHECK(result);

« no previous file with comments | « base/json/json_value_converter.h ('k') | base/values.h » ('j') | no next file with comments »