content/browser/speech/google_one_shot_remote_engine.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_one_shot_remote_engine.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options2/autofill_options_handler.cc ('K') | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/renderer/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/google_one_shot_remote_engine.cc

diff --git a/content/browser/speech/google_one_shot_remote_engine.cc b/content/browser/speech/google_one_shot_remote_engine.cc

index d56986b7282819e64bf27fe8de3d79292fcb500b..3c2e2921342719cb2df6c05c1d2acfe95f84a00b 100644

--- a/content/browser/speech/google_one_shot_remote_engine.cc

+++ b/content/browser/speech/google_one_shot_remote_engine.cc

@@ -110,7 +110,7 @@ bool ParseServerResponse(const std::string& response_body,

// final result, consisting of one fragment (with one or more hypotheses).

size_t index = 0;

for (; index < hypotheses_list->GetSize(); ++index) {

- Value* hypothesis = NULL;

+ const Value* hypothesis = NULL;

if (!hypotheses_list->Get(index, &hypothesis)) {

LOG(WARNING) << "ParseServerResponse: Unable to read hypothesis value.";

break;

@@ -123,7 +123,7 @@ bool ParseServerResponse(const std::string& response_body,

}

const DictionaryValue* hypothesis_value =

- static_cast<DictionaryValue*>(hypothesis);

+ static_cast<const DictionaryValue*>(hypothesis);

string16 utterance;

if (!hypothesis_value->GetString(kUtteranceString, &utterance)) {