chrome/common/extensions/extension.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options2/autofill_options_handler.cc ('K') | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/net/gaia/oauth2_mint_token_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 990271e17965fb76156cfce707cc728c617aec50..305deea6744e5127afdf9409224eea35120486f3 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -726,7 +726,7 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,

if (js) {

for (size_t script_index = 0; script_index < js->GetSize();

++script_index) {

- Value* value;

+ const Value* value;

std::string relative;

if (!js->Get(script_index, &value) || !value->GetAsString(&relative)) {

*error = ExtensionErrorUtils::FormatErrorMessageUTF16(

@@ -745,7 +745,7 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,

if (css) {

for (size_t script_index = 0; script_index < css->GetSize();

++script_index) {

- Value* value;

+ const Value* value;

std::string relative;

if (!css->Get(script_index, &value) || !value->GetAsString(&relative)) {

*error = ExtensionErrorUtils::FormatErrorMessageUTF16(