Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: chrome/browser/ui/webui/options2/core_options_handler.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options2/core_options_handler.cc b/chrome/browser/ui/webui/options2/core_options_handler.cc
index f0ddbf94137e3b465814dbf188bc6664f2ca1782..5a2b5c715cccc6336866ffe8cde22181eaf79d04 100644
--- a/chrome/browser/ui/webui/options2/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options2/core_options_handler.cc
@@ -298,7 +298,7 @@ void CoreOptionsHandler::HandleFetchPrefs(const ListValue* args) {
DCHECK_GE(static_cast<int>(args->GetSize()), 2);
// Get callback JS function name.
- base::Value* callback;
+ const base::Value* callback;
if (!args->Get(0, &callback) || !callback->IsType(base::Value::TYPE_STRING))
return;
@@ -308,7 +308,7 @@ void CoreOptionsHandler::HandleFetchPrefs(const ListValue* args) {
// Get the list of name for prefs to build the response dictionary.
DictionaryValue result_value;
- base::Value* list_member;
+ const base::Value* list_member;
for (size_t i = 1; i < args->GetSize(); i++) {
if (!args->Get(i, &list_member))
@@ -339,7 +339,7 @@ void CoreOptionsHandler::HandleObservePrefs(const ListValue* args) {
// Get all other parameters - pref identifiers.
for (size_t i = 1; i < args->GetSize(); i++) {
- base::Value* list_member;
+ const base::Value* list_member;
if (!args->Get(i, &list_member))
break;
@@ -389,7 +389,7 @@ void CoreOptionsHandler::HandleSetPref(const ListValue* args, PrefType type) {
if (!args->GetString(0, &pref_name))
return;
- base::Value* value;
+ const base::Value* value;
if (!args->Get(1, &value))
return;

Powered by Google App Engine
This is Rietveld 408576698