chrome/browser/extensions/extension_management_api.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | chrome/browser/extensions/extension_web_ui.h » ('j') | chrome/browser/ui/webui/options2/autofill_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_api.cc

diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc

index 291e3ddaa4180f1828f84b17aa206cb31d1b3761..b77d7f1d9e37643c729fcf1cf8e648da662f6fc5 100644

--- a/chrome/browser/extensions/extension_management_api.cc

+++ b/chrome/browser/extensions/extension_management_api.cc

@@ -246,10 +246,11 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {

void OnJSONParseSucceeded(const ListValue& wrapper) {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

- Value* value = NULL;

+ const Value* value = NULL;

CHECK(wrapper.Get(0, &value));

if (value->IsType(Value::TYPE_DICTIONARY))

- parsed_manifest_.reset(static_cast<DictionaryValue*>(value)->DeepCopy());

+ parsed_manifest_.reset(

+ static_cast<const DictionaryValue*>(value)->DeepCopy());

else

error_ = keys::kManifestParseError;