Correct const accessors in base/values.(h|cc), Part II (ListValue)

chrome/browser/web_resource/notification_promo.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/notification_promo.h"
 
 #include <cmath>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 208 matching lines @@
   if (!json.GetList(promo_type_, &promo_list))
     return;
 #else
   if (!json.GetList("mobile_ntp_sync_promo", &promo_list)) {
     LOG(ERROR) << "Malfromed JSON: not a mobile_ntp_sync_promo";
     return;
   }
 #endif  // !defined(OS_ANDROID)
 
   // No support for multiple promos yet. Only consider the first one.
-  DictionaryValue* promo = NULL;
+  const DictionaryValue* promo = NULL;
   if (!promo_list->GetDictionary(0, &promo))
     return;
 
   // Strings. Assume the first one is the promo text.
-  DictionaryValue* strings = NULL;
+  const DictionaryValue* strings = NULL;
   if (promo->GetDictionary("strings", &strings)) {
 #if !defined(OS_ANDROID)
     DictionaryValue::Iterator iter(*strings);
     iter.value().GetAsString(&promo_text_);
     DVLOG(1) << "promo_text_=" << promo_text_;
 #endif  // defined(OS_ANDROID)
   }
 
   // Date.
-  ListValue* date_list = NULL;
+  const ListValue* date_list = NULL;
   if (promo->GetList("date", &date_list)) {
-    DictionaryValue* date;
+    const DictionaryValue* date;
     if (date_list->GetDictionary(0, &date)) {
       std::string time_str;
       base::Time time;
       if (date->GetString("start", &time_str) &&
           base::Time::FromString(time_str.c_str(), &time)) {
         start_ = time.ToDoubleT();
         DVLOG(1) << "start str=" << time_str
                  << ", start_="<< base::DoubleToString(start_);
       }
       if (date->GetString("end", &time_str) &&
           base::Time::FromString(time_str.c_str(), &time)) {
         end_ = time.ToDoubleT();
         DVLOG(1) << "end str =" << time_str
                  << ", end_=" << base::DoubleToString(end_);
       }
     }
   }
 
   // Grouping.
-  DictionaryValue* grouping = NULL;
+  const DictionaryValue* grouping = NULL;
   if (promo->GetDictionary("grouping", &grouping)) {
     grouping->GetInteger("buckets", &num_groups_);
     grouping->GetInteger("segment", &initial_segment_);
     grouping->GetInteger("increment", &increment_);
     grouping->GetInteger("increment_frequency", &time_slice_);
     grouping->GetInteger("increment_max", &max_group_);
 
     DVLOG(1) << "num_groups_ = " << num_groups_
              << ", initial_segment_ = " << initial_segment_
              << ", increment_ = " << increment_
              << ", time_slice_ = " << time_slice_
              << ", max_group_ = " << max_group_;
   }
 
   // Payload.
-  DictionaryValue* payload = NULL;
+  const DictionaryValue* payload = NULL;
   if (promo->GetDictionary("payload", &payload)) {
     payload->GetBoolean("gplus_required", &gplus_required_);
 
     DVLOG(1) << "gplus_required_ = " << gplus_required_;
   }
 
   promo->GetInteger("max_views", &max_views_);
   DVLOG(1) << "max_views_ " << max_views_;
 
 #if defined(OS_ANDROID)
@@ skipping 17 matching lines @@
   if (!payload->GetString("promo_message_short", &promo_key_short) ||
       !payload->GetString("promo_message_long", &promo_key_long) ||
       !strings->GetString(promo_key_short, &promo_text_) ||
       !strings->GetString(promo_key_long, &promo_text_long_)) {
     LOG(ERROR) << "Malformed JSON: no promo_message_short or _long";
     return;
   }
   payload->GetString("promo_action_type", &promo_action_type_);
   // We need to be idempotent as the tests call us more than once.
   promo_action_args_.reset(new base::ListValue);
-  ListValue* args;
+  const ListValue* args;
   if (payload->GetList("promo_action_args", &args)) {
     // JSON format for args: "promo_action_args" : [ "<arg1>", "<arg2>"... ]
     // Every value comes from "strings" dictionary, either directly or not.
     // Every arg is either directly a key into "strings" dictionary,
     // or a key into "payload" dictionary with the value that is a key into
     // "strings" dictionary.
     for (std::size_t i = 0; i < args->GetSize(); ++i) {
       std::string name, key, value;
       if (!args->GetString(i, &name) ||
           !(strings->GetString(name, &value) ||
@@ skipping 77 matching lines @@
   const base::DictionaryValue* promo_dict =
       prefs_->GetDictionary(kPrefPromoObject);
   if (!promo_dict)
     return;
 
   const base::ListValue* promo_list(NULL);
   promo_dict->GetList(promo_type_, &promo_list);
   if (!promo_list)
     return;
 
-  base::DictionaryValue* ntp_promo(NULL);
+  const base::DictionaryValue* ntp_promo(NULL);
   promo_list->GetDictionary(0, &ntp_promo);
   if (!ntp_promo)
     return;
 
   ntp_promo->GetString(kPrefPromoText, &promo_text_);
 #if defined(OS_ANDROID)
   ntp_promo->GetString(kPrefPromoTextLong, &promo_text_long_);
   ntp_promo->GetString(kPrefPromoActionType, &promo_action_type_);
-  base::ListValue* lv(NULL);
+  const base::ListValue* lv(NULL);
   ntp_promo->GetList(kPrefPromoActionArgs, &lv);
   DCHECK(lv != NULL);
   promo_action_args_.reset(lv->DeepCopy());
 #endif  // defined(OS_ANDROID)
 
   ntp_promo->GetDouble(kPrefPromoStart, &start_);
   ntp_promo->GetDouble(kPrefPromoEnd, &end_);
 
   ntp_promo->GetInteger(kPrefPromoNumGroups, &num_groups_);
   ntp_promo->GetInteger(kPrefPromoSegment, &initial_segment_);
@@ skipping 67 matching lines @@
   if (group_ < initial_segment_)
     return start_;
   return start_ +
       std::ceil(static_cast<float>(group_ - initial_segment_ + 1) / increment_)
       * time_slice_;
 }
 
 double NotificationPromo::EndTime() const {
   return end_;
 }