Correct const accessors in base/values.(h|cc), Part II (ListValue)

chrome/browser/net/predictor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <time.h>
 
 #include <algorithm>
 #include <sstream>
 #include <string>
 
@@ skipping 229 matching lines @@
 
   testing_master.Shutdown();
 }
 
 //------------------------------------------------------------------------------
 // Functions to help synthesize and test serializations of subresource referrer
 // lists.
 
 // Return a motivation_list if we can find one for the given motivating_host (or
 // NULL if a match is not found).
-static ListValue* FindSerializationMotivation(const GURL& motivation,
-                                              const ListValue& referral_list) {
-  CHECK_LT(0u, referral_list.GetSize());  // Room for version.
+static const ListValue* FindSerializationMotivation(
+    const GURL& motivation,
+    const ListValue* referral_list) {
+  CHECK_LT(0u, referral_list->GetSize());  // Room for version.
   int format_version = -1;
-  CHECK(referral_list.GetInteger(0, &format_version));
+  CHECK(referral_list->GetInteger(0, &format_version));
   CHECK_EQ(Predictor::kPredictorReferrerVersion, format_version);
-  ListValue* motivation_list(NULL);
-  for (size_t i = 1; i < referral_list.GetSize(); ++i) {
-    referral_list.GetList(i, &motivation_list);
+  const ListValue* motivation_list(NULL);
+  for (size_t i = 1; i < referral_list->GetSize(); ++i) {
+    referral_list->GetList(i, &motivation_list);
     std::string existing_spec;
     EXPECT_TRUE(motivation_list->GetString(0, &existing_spec));
     if (motivation == GURL(existing_spec))
       return motivation_list;
   }
   return NULL;
 }
 
+static ListValue* FindSerializationMotivation(const GURL& motivation,
+                                              ListValue* referral_list) {
+  return const_cast<ListValue*>(FindSerializationMotivation(
+      motivation, static_cast<const ListValue*>(referral_list)));
+}
+
 // Create a new empty serialization list.
 static ListValue* NewEmptySerializationList() {
   base::ListValue* list = new base::ListValue;
   list->Append(
       new base::FundamentalValue(Predictor::kPredictorReferrerVersion));
   return list;
 }
 
 // Add a motivating_url and a subresource_url to a serialized list, using
 // this given latency. This is a helper function for quickly building these
 // lists.
 static void AddToSerializedList(const GURL& motivation,
                                 const GURL& subresource,
                                 double use_rate,
                                 ListValue* referral_list ) {
   // Find the motivation if it is already used.
   ListValue* motivation_list = FindSerializationMotivation(motivation,
-                                                           *referral_list);
+                                                           referral_list);
   if (!motivation_list) {
     // This is the first mention of this motivation, so build a list.
     motivation_list = new ListValue;
     motivation_list->Append(new StringValue(motivation.spec()));
     // Provide empty subresource list.
     motivation_list->Append(new ListValue());
 
     // ...and make it part of the serialized referral_list.
     referral_list->Append(motivation_list);
   }
@@ skipping 13 matching lines @@
 static const int kLatencyNotFound = -1;
 
 // For a given motivation, and subresource, find what latency is currently
 // listed.  This assume a well formed serialization, which has at most one such
 // entry for any pair of names.  If no such pair is found, then return false.
 // Data is written into use_rate arguments.
 static bool GetDataFromSerialization(const GURL& motivation,
                                      const GURL& subresource,
                                      const ListValue& referral_list,
                                      double* use_rate) {
-  ListValue* motivation_list = FindSerializationMotivation(motivation,
-                                                           referral_list);
+  const ListValue* motivation_list =
+      FindSerializationMotivation(motivation, &referral_list);
   if (!motivation_list)
     return false;
-  ListValue* subresource_list;
+  const ListValue* subresource_list;
   EXPECT_TRUE(motivation_list->GetList(1, &subresource_list));
   for (size_t i = 0; i < subresource_list->GetSize();) {
     std::string url_spec;
     EXPECT_TRUE(subresource_list->GetString(i++, &url_spec));
     EXPECT_TRUE(subresource_list->GetDouble(i++, use_rate));
     if (subresource == GURL(url_spec)) {
       return true;
     }
   }
   return false;
@@ skipping 335 matching lines @@
   EXPECT_EQ(2U, referral_list.GetSize());
 
   predictor.DiscardAllResults();
   predictor.SerializeReferrers(&referral_list);
   EXPECT_EQ(1U, referral_list.GetSize());
 
   predictor.Shutdown();
 }
 
 }  // namespace chrome_browser_net