Correct const accessors in base/values.(h|cc), Part II (ListValue)

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 5093 matching lines @@
     cards->Append(card_info);
   }
   return cards;
 }
 
 /* static */
 std::vector<AutofillProfile>
 TestingAutomationProvider::GetAutofillProfilesFromList(
     const ListValue& profiles, std::string* error_message) {
   std::vector<AutofillProfile> autofill_profiles;
-  DictionaryValue* profile_info = NULL;
-  ListValue* current_value = NULL;
+  const DictionaryValue* profile_info = NULL;
+  const ListValue* current_value = NULL;
 
   std::map<AutofillFieldType, std::string> autofill_type_to_string =
       GetAutofillFieldToStringMap();
 
   int num_profiles = profiles.GetSize();
   for (int i = 0; i < num_profiles; i++) {
     profiles.GetDictionary(i, &profile_info);
     AutofillProfile profile;
     // Loop through the possible profile types and add those provided.
     for (std::map<AutofillFieldType, std::string>::iterator type_it =
          autofill_type_to_string.begin();
          type_it != autofill_type_to_string.end(); ++type_it) {
       if (profile_info->HasKey(type_it->second)) {
         if (profile_info->GetList(type_it->second, &current_value)) {
           std::vector<string16> value_list;
-          for (ListValue::iterator list_it = current_value->begin();
+          for (ListValue::const_iterator list_it = current_value->begin();
                list_it != current_value->end(); ++list_it) {
             string16 value;
             if ((*list_it)->GetAsString(&value)) {
               value_list.insert(value_list.end(), value);
             } else {
               *error_message = "All list values must be strings";
               return autofill_profiles;
             }
           }
           profile.SetMultiInfo(type_it->first, value_list);
         } else {
           *error_message= "All values must be lists";
           return autofill_profiles;
         }
       }
     }
     autofill_profiles.push_back(profile);
   }
   return autofill_profiles;
 }
 
 /* static */
 std::vector<CreditCard> TestingAutomationProvider::GetCreditCardsFromList(
     const ListValue& cards, std::string* error_message) {
   std::vector<CreditCard> credit_cards;
-  DictionaryValue* card_info = NULL;
+  const DictionaryValue* card_info = NULL;
   string16 current_value;
 
   std::map<AutofillFieldType, std::string> credit_card_type_to_string =
       GetCreditCardFieldToStringMap();
 
   int num_credit_cards = cards.GetSize();
   for (int i = 0; i < num_credit_cards; i++) {
     if (!cards.GetDictionary(i, &card_info))
       continue;
     CreditCard card;
@@ skipping 1916 matching lines @@
 void TestingAutomationProvider::OnRemoveProvider() {
   if (g_browser_process)
     g_browser_process->GetAutomationProviderList()->RemoveProvider(this);
 }
 
 void TestingAutomationProvider::EnsureTabSelected(Browser* browser,
                                                   WebContents* tab) {
   if (chrome::GetActiveWebContents(browser) != tab)
     chrome::ActivateTabAt(browser, chrome::GetIndexOfTab(browser, tab), true);
 }