Initial iOS bring up of ui.

ui/ui.gyp

Index: ui/ui.gyp
diff --git a/ui/ui.gyp b/ui/ui.gyp
index ef2b48ac4241820b1ed27512d5ab83c53e4a788e..a81638f0af20205e9606ecedf0fa4d924863c8f7 100644
--- a/ui/ui.gyp
+++ b/ui/ui.gyp
@@ -19,19 +19,12 @@
       ],
       'dependencies': [
         '../base/base.gyp:base',
-        '../base/base.gyp:base_i18n',
-        '../base/base.gyp:base_static',

[stuartmorgan, 2012/08/01 13:26:18]

Why do we have to remove these?

         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../net/net.gyp:net',
         '../skia/skia.gyp:skia',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
-        '../third_party/libpng/libpng.gyp:libpng',
-        '../third_party/zlib/zlib.gyp:zlib',

[stuartmorgan, 2012/08/01 13:26:18]

And this?

-        'base/strings/ui_strings.gyp:ui_strings',
-        'ui_resources',

[stuartmorgan, 2012/08/01 13:26:18]

Can't we use dependencies! for some of these?

[noyau (Ping after 24h), 2012/08/01 13:53:45]

I restored them all except for libjpeg, which cannot be excluded with
dependencies! as it is not present.

-        '<(libjpeg_gyp_path):libjpeg',
       ],
       'defines': [
         'UI_IMPLEMENTATION',
@@ -407,6 +400,7 @@
         'gfx/point_base.h',
         'gfx/point_f.cc',
         'gfx/point_f.h',
+        'gfx/point3.h',
         'gfx/rect.cc',
         'gfx/rect.h',
         'gfx/rect_base.h',
@@ -466,6 +460,18 @@
         'ui_controls/ui_controls_win.cc',
       ],
       'conditions': [
+        ['OS != "ios"', {
+            'dependencies': [

[stuartmorgan, 2012/08/01 13:26:18]

Indentation is wrong here.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

+              '../base/base.gyp:base_i18n',
+              '../base/base.gyp:base_static',
+              '../third_party/libpng/libpng.gyp:libpng',
+              '../third_party/zlib/zlib.gyp:zlib',
+              'base/strings/ui_strings.gyp:ui_strings',
+              'ui_resources',
+              '<(libjpeg_gyp_path):libjpeg',
+            ],
+          },
+        ],

[stuartmorgan, 2012/08/01 13:26:18]

And this should be on the previous line, with the comma from the previous line
removed.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

         # TODO(asvitkine): Switch all platforms to use canvas_skia.cc.
         #                  http://crbug.com/105550
         ['use_canvas_skia==1', {
@@ -548,7 +554,7 @@
           ],
           'link_settings': {
             'libraries': [
-              '-lXcursor',  # For XCursor* function calls in x11_util.cc. 
+              '-lXcursor',  # For XCursor* function calls in x11_util.cc.
               '-lXrender',  # For XRender* function calls in x11_util.cc.
             ],
           },
@@ -677,7 +683,30 @@
             ],
           },
         }],
-        ['use_x11==1', {
+        ['OS == "ios"', {

[stuartmorgan, 2012/08/01 13:26:18]

Everything else in this block has the no-spaces style, so let's match that.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

+          'sources/': [
+            # iOS uses so little of ui that it is is easier to simply exclude
+            # everything and then just select the parts needed.

[stuartmorgan, 2012/08/01 13:26:18]

Will this always be true? If not, change to a TODO; if so, add a TODO after it
to add files here as they are made iOS-ready, so it's clear this isn't a final
list.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

+            ['exclude', '^base/'],
+            ['exclude', '^ui_controls/'],
+            ['exclude', '^gfx/'],
+            ['include', '^gfx/point\\.'],
+            ['include', '^gfx/point_base\\.h'],
+            ['include', '^gfx/point3\\.h'],
+            ['include', '^gfx/rect\\.'],
+            ['include', '^gfx/rect_base\\.h'],
+            ['include', '^gfx/rect_base_impl\\.h'],
+            ['include', '^gfx/size\\.'],
+            ['include', '^gfx/size_base\\.h'],
+            ['include', '^gfx/size_base_impl\\.h'],
+          ],
+          'link_settings': {
+            'libraries': [
+            '$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework',

[stuartmorgan, 2012/08/01 13:26:18]

Indent more.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

+            ],
+          },
+        }],
+        ['use_x11 == 1', {

[stuartmorgan, 2012/08/01 13:26:18]

Don't change the spacing here.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

           'all_dependent_settings': {
             'ldflags': [
               '-L<(PRODUCT_DIR)',
@@ -729,7 +758,18 @@
     },
   ],
   'conditions': [
-    ['inside_chromium_build==1', {
+    [ 'OS == "ios"', {
+      'targets': [
+        {
+          # TODO(ios): Adding a fake target so the bots have something to invoke
+          # while the tests are disabled. See b/4935009.
+          'target_name': 'gfx_unittests',
+          'type': 'none',
+        }
+      ],
+    }],

[stuartmorgan, 2012/08/01 13:26:18]

This block shouldn't be necessary upstream; nothing runs unit tests yet.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

+    ['inside_chromium_build == 1 and OS != "ios"', {
+      # TODO(ios): The ui tests do not compile yet on iOS. See b/4935009.

[stuartmorgan, 2012/08/01 13:26:18]

That bug has nothing to do with compiling AFAICT. Just remove the bug reference;
this early in the ui/ upstreaming the TODO speaks for itself.

[noyau (Ping after 24h), 2012/08/01 13:53:45]

Done.

       'includes': [
         'ui_unittests.gypi',
       ],