Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10837013: Chrome Cloud Messaging (Closed)

Created:
8 years, 4 months ago by dcheng
Modified:
8 years, 1 month ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing), Munjal (Google), Pete Williamson, Dmitry Titov
Visibility:
Public.

Description

Chrome Cloud Messaging Implements a basic handler to help register/unregister extensions with Tango, as well as a basic API test to see if event dispatching works as expected. This depends on http://codereview.chromium.org/10805002/ to land. Right now, we just don't register anything. BUG=135232 TEST=an extension with the <insert permission name here> should receive notifications associated with it. This change is probably going to get broken up into at least two smaller changes: - One containing just the InvalidationHandler changes. - One containing the plumbing for events so we can have a basic API test.

Patch Set 1 #

Patch Set 2 : Now with tests #

Patch Set 3 : push -> push_messaging #

Patch Set 4 : Rebase #

Patch Set 5 : InvalidationHandler + event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -0 lines) Patch
A chrome/browser/extensions/api/push_messaging/invalidation_handler.h View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/invalidation_handler.cc View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/invalidation_handler_observer.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/invalidation_handler_unittest.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetch.h View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetch.cc View 1 2 1 chunk +149 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/push_messaging_api.h View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 1 2 3 4 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/experimental_push_messaging.idl View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/push_messaging/event.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/push_messaging/event.js View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/push_messaging/manifest.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698