Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10837006: Blacklist all GPU access on Lion with Intel HD 4000. (Closed)

Created:
8 years, 4 months ago by Zhenyao Mo
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews), jam, apatrick_chromium
Visibility:
Public.

Description

Blacklist all GPU access on Lion with Intel HD 4000. We have to do this to avoid potential kernel panic. Will remove this entry once Apple fixes the issue and pushes the updates to users. BUG=134015 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149084

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M chrome/browser/resources/software_rendering_list.json View 1 3 chunks +36 lines, -16 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
Please have a look.
8 years, 4 months ago (2012-07-30 20:19:12 UTC) #1
Ken Russell (switch to Gerrit)
lgtm http://codereview.chromium.org/10837006/diff/4002/chrome/browser/resources/software_rendering_list.json File chrome/browser/resources/software_rendering_list.json (right): http://codereview.chromium.org/10837006/diff/4002/chrome/browser/resources/software_rendering_list.json#newcode654 chrome/browser/resources/software_rendering_list.json:654: "number": "10.7" Will this match all 10.7 releases ...
8 years, 4 months ago (2012-07-30 21:31:39 UTC) #2
Zhenyao Mo
8 years, 4 months ago (2012-07-30 21:32:28 UTC) #3
http://codereview.chromium.org/10837006/diff/4002/chrome/browser/resources/so...
File chrome/browser/resources/software_rendering_list.json (right):

http://codereview.chromium.org/10837006/diff/4002/chrome/browser/resources/so...
chrome/browser/resources/software_rendering_list.json:654: "number": "10.7"
On 2012/07/30 21:31:39, kbr wrote:
> Will this match all 10.7 releases (e.g. 10.7.4)?

Yes, this matches 10.7.*

Powered by Google App Engine
This is Rietveld 408576698