Issue 10836356: Add a dependency on Xrandr since it fails to link DumpRenderTree of WebKit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836356: Add a dependency on Xrandr since it fails to link DumpRenderTree of WebKit. (Closed)

Created:
8 years, 4 months ago by Jun Mukai

Modified:
8 years, 4 months ago

Reviewers:
Daniel Erat, tasak, sky

CC:
chromium-reviews, Michael Moss, yurys

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add a dependency on Xrandr since it fails to link DumpRenderTree of WebKit. TBR=sky@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152554

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/ui.gyp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Daniel Erat

+mmoss: do package dependencies or build deps need to be manually updated?

8 years, 4 months ago (2012-08-21 12:25:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10836356/1

8 years, 4 months ago (2012-08-21 12:53:50 UTC) #5

commit-bot: I haz the power

Presubmit check for 10836356-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 4 months ago (2012-08-21 12:53:53 UTC) #6

Jun Mukai

8 years, 4 months ago (2012-08-21 14:18:32 UTC) #7

As per the discussion with yurys, I will dcommit this CL with TBR.  thanks.