Panels test cleanup.

chrome/browser/ui/panels/panel_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
@@ skipping 326 matching lines @@
   gfx::Size new_size(event->width, event->height);
   if (new_size == configure_size_)
     return FALSE;
 
   UpdateWindowShape(event->width, event->height);
   configure_size_ = new_size;
 
   if (!GetFrameSize().IsEmpty())
     return FALSE;
 
-  // Save the frame size allocated by the system after as the
+  // Save the frame size allocated by the system as the
   // frame size will be affected when we shrink the panel smaller
   // than the frame (e.g. when the panel is minimized).
   SetFrameSize(GetNonClientFrameSize());
   panel_->OnWindowSizeAvailable();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_WINDOW_SIZE_KNOWN,
       content::Source<Panel>(panel_.get()),
       content::NotificationService::NoDetails());
 
@@ skipping 399 matching lines @@
 }
 
 void PanelGtk::SetPanelBoundsInstantly(const gfx::Rect& bounds) {
   SetBoundsInternal(bounds, false);
 }
 
 void PanelGtk::SetBoundsInternal(const gfx::Rect& bounds, bool animate) {
   if (bounds == bounds_)
     return;
 
-  if (!animate) {
-    // If no animation is in progress, apply bounds change instantly. Otherwise,
-    // continue the animation with new target bounds.
-    if (!IsAnimatingBounds())
-      gdk_window_move_resize(gtk_widget_get_window(GTK_WIDGET(window_)),
-                             bounds.x(), bounds.y(),
-                             bounds.width(), bounds.height());
-  } else if (is_shown_) {
-    StartBoundsAnimation(bounds_, bounds);
+  if (is_shown_) {
+    if (!animate) {
+      // If no animation is in progress, apply bounds change instantly.
+      // Otherwise, continue the animation with new target bounds.
+      if (!IsAnimatingBounds())
+        gdk_window_move_resize(gtk_widget_get_window(GTK_WIDGET(window_)),
+                               bounds.x(), bounds.y(),
+                               bounds.width(), bounds.height());
+    } else if (is_shown_) {

[jianli, 2012/08/18 00:07:57]

Is this if necessary?

[jennb, 2012/08/18 00:28:04]

Good catch!

+      StartBoundsAnimation(bounds_, bounds);
+    }
   }
 
   bounds_ = bounds;
 }
 
 void PanelGtk::ClosePanel() {
   // We're already closing.  Do nothing.
   if (!window_)
     return;
 
@@ skipping 396 matching lines @@
       break;
     case panel::RESTORE_BUTTON:
       button = titlebar->restore_button();
       break;
     default:
       NOTREACHED();
       return false;
   }
   return gtk_widget_get_visible(button->widget());
 }