Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: content/public/browser/browser_context.h

Issue 10836305: Ensure that isolated apps use the right cookies for media requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_context.h
diff --git a/content/public/browser/browser_context.h b/content/public/browser/browser_context.h
index cfe4d53f5e396675460b1fb31f34bdbb0f0b9c68..cd54228184ecaa37a89ac813ae06146c0f8d9455 100644
--- a/content/public/browser/browser_context.h
+++ b/content/public/browser/browser_context.h
@@ -89,20 +89,25 @@ class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
// Returns the request context information associated with this context. Call
// this only on the UI thread, since it can send notifications that should
// happen on the UI thread.
+ // TODO(creis): Remove this version in favor of the one below.
virtual net::URLRequestContextGetter* GetRequestContext() = 0;
// Returns the request context appropriate for the given renderer. If the
// renderer process doesn't have an associated installed app, or if the
// installed app's is_storage_isolated() returns false, this is equivalent to
// calling GetRequestContext().
- // TODO(creis): After isolated app storage is no longer an experimental
- // feature, consider making this the default contract for GetRequestContext.
virtual net::URLRequestContextGetter* GetRequestContextForRenderProcess(
int renderer_child_id) = 0;
+ // Returns the default request context for media resources associated with
+ // this context.
+ // TODO(creis): Remove this version in favor of the one below.
+ virtual net::URLRequestContextGetter* GetDefaultRequestContextForMedia() = 0;
+
// Returns the request context for media resources associated with this
- // context.
- virtual net::URLRequestContextGetter* GetRequestContextForMedia() = 0;
+ // context and renderer process.
+ virtual net::URLRequestContextGetter* GetRequestContextForMedia(
+ int renderer_child_id) = 0;
// Returns the resource context.
virtual ResourceContext* GetResourceContext() = 0;

Powered by Google App Engine
This is Rietveld 408576698