Issue 10836298: Fix crash for the toast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836298: Fix crash for the toast (Closed)

Created:
8 years, 4 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash for the toast Toast flavors 0 and 1 are affected because we dereference a null pointer BUG=129499 TEST=see bug TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151990

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/first_run/try_chrome_dialog_view.cc	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 4 months ago (2012-08-16 23:11:45 UTC) #2

LGTM

http://codereview.chromium.org/10836298/diff/1/chrome/browser/first_run/try_c...
File chrome/browser/first_run/try_chrome_dialog_view.cc (right):

http://codereview.chromium.org/10836298/diff/1/chrome/browser/first_run/try_c...
chrome/browser/first_run/try_chrome_dialog_view.cc:338: if (make_default_) {
combine into a single if.

Expand Messages | Collapse Messages