Chromium Code Reviews| Index: sync/util/get_session_name.cc |
| diff --git a/sync/util/get_session_name.cc b/sync/util/get_session_name.cc |
| index 99a4ce01e51978b25c88bf5188f39e68f2ce29f3..5213f1e71f27592c33045985245a57772296bc64 100644 |
| --- a/sync/util/get_session_name.cc |
| +++ b/sync/util/get_session_name.cc |
| @@ -30,7 +30,7 @@ namespace { |
| std::string GetSessionNameSynchronously() { |
| std::string session_name; |
| #if defined(OS_CHROMEOS) |
| - // TODO(kochi): This is very ad hoc and fragile. http://crosbug.com/30619. |
| + // TODO(kochi): This is very ad hoc and fragile. http://crbug.com/126732. |
| std::string board; |
| const char kMachineInfoBoard[] = "CHROMEOS_RELEASE_BOARD"; |
| chromeos::system::StatisticsProvider* provider = |
| @@ -38,8 +38,10 @@ std::string GetSessionNameSynchronously() { |
| if (!provider->GetMachineStatistic(kMachineInfoBoard, &board)) |
| LOG(ERROR) << "Failed to get board information"; |
| // Currently, only "stumpy" type of board is considered Chromebox, and |
| - // anything else is Chromebook. |
| - session_name = (board == "stumpy") ? "Chromebox" : "Chromebook"; |
| + // anything else is Chromebook. On these devices, session_name should look |
| + // like "stumpy-signed-mp-v2keys" etc. The information can be checked on |
| + // "CHROMEOS_RELEASE_BOARD" line in chrome://system. |
| + session_name = board.find("stumpy") == 0 ? "Chromebox" : "Chromebook"; |
|
Nicolas Zea
2012/08/15 20:53:04
Nit: do we want to enforce that "stumpy" is always
kochi
2012/08/16 01:22:06
Done.
I don't have strong preference to either, b
|
| #elif defined(OS_LINUX) |
| session_name = base::GetLinuxDistro(); |
| #elif defined(OS_MACOSX) |