Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: net/url_request/url_request_job_factory_unittest.cc

Issue 10836248: Turned job_factory into a pure virtual class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed includes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job_factory_unittest.cc
diff --git a/net/url_request/url_request_job_factory_unittest.cc b/net/url_request/url_request_job_factory_unittest.cc
index a87c7173f511a68b4522e43d71b8028509c3e03c..251e0d1ce5338cccc50eae0219b9ea5e15137ca4 100644
--- a/net/url_request/url_request_job_factory_unittest.cc
+++ b/net/url_request/url_request_job_factory_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "net/url_request/url_request_job_factory.h"
+#include "net/url_request/url_request_job_factory_impl.h"
#include "base/bind.h"
#include "base/memory/weak_ptr.h"
@@ -100,7 +100,7 @@ TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
@@ -113,7 +113,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
}
TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
@@ -122,7 +122,7 @@ TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
TEST(URLRequestJobFactoryTest, BasicInterceptor) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.AddInterceptor(new DummyInterceptor);
@@ -136,7 +136,7 @@ TEST(URLRequestJobFactoryTest, BasicInterceptor) {
TEST(URLRequestJobFactoryTest, InterceptorNeedsValidSchemeStill) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.AddInterceptor(new DummyInterceptor);
@@ -150,7 +150,7 @@ TEST(URLRequestJobFactoryTest, InterceptorNeedsValidSchemeStill) {
TEST(URLRequestJobFactoryTest, InterceptorOverridesProtocolHandler) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
@@ -165,7 +165,7 @@ TEST(URLRequestJobFactoryTest, InterceptorOverridesProtocolHandler) {
TEST(URLRequestJobFactoryTest, InterceptorDoesntInterceptUnknownProtocols) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
DummyInterceptor* interceptor = new DummyInterceptor;
@@ -179,7 +179,7 @@ TEST(URLRequestJobFactoryTest, InterceptorDoesntInterceptUnknownProtocols) {
TEST(URLRequestJobFactoryTest, InterceptorInterceptsHandledUnknownProtocols) {
TestDelegate delegate;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
DummyInterceptor* interceptor = new DummyInterceptor;
@@ -196,7 +196,7 @@ TEST(URLRequestJobFactoryTest, InterceptorInterceptsHandledUnknownProtocols) {
TEST(URLRequestJobFactoryTest, InterceptorAffectsIsHandledProtocol) {
DummyInterceptor* interceptor = new DummyInterceptor;
- URLRequestJobFactory job_factory;
+ URLRequestJobFactoryImpl job_factory;
job_factory.AddInterceptor(interceptor);
EXPECT_FALSE(interceptor->WillHandleProtocol("anything"));
EXPECT_FALSE(job_factory.IsHandledProtocol("anything"));

Powered by Google App Engine
This is Rietveld 408576698