Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: net/url_request/url_request_job_factory.cc

Issue 10836248: Turned job_factory into a pure virtual class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job_factory.cc
diff --git a/net/url_request/url_request_job_factory.cc b/net/url_request/url_request_job_factory.cc
index 44bc0024170c3ae68135b5e73ee65839b29fee28..e07152abee080ebe9c9d62391d15f4e8cef43cd6 100644
--- a/net/url_request/url_request_job_factory.cc
+++ b/net/url_request/url_request_job_factory.cc
@@ -4,11 +4,6 @@
#include "net/url_request/url_request_job_factory.h"
-#include "base/stl_util.h"
-#include "googleurl/src/gurl.h"
-#include "net/base/load_flags.h"
-#include "net/url_request/url_request_job_manager.h"
-
namespace net {
URLRequestJobFactory::ProtocolHandler::~ProtocolHandler() {}
@@ -22,115 +17,6 @@ bool URLRequestJobFactory::Interceptor::WillHandleProtocol(
URLRequestJobFactory::URLRequestJobFactory() {}
-URLRequestJobFactory::~URLRequestJobFactory() {
- STLDeleteValues(&protocol_handler_map_);
- STLDeleteElements(&interceptors_);
-}
-
-bool URLRequestJobFactory::SetProtocolHandler(
- const std::string& scheme,
- ProtocolHandler* protocol_handler) {
- DCHECK(CalledOnValidThread());
-
- if (!protocol_handler) {
- ProtocolHandlerMap::iterator it = protocol_handler_map_.find(scheme);
- if (it == protocol_handler_map_.end())
- return false;
-
- delete it->second;
- protocol_handler_map_.erase(it);
- return true;
- }
-
- if (ContainsKey(protocol_handler_map_, scheme))
- return false;
- protocol_handler_map_[scheme] = protocol_handler;
- return true;
-}
-
-void URLRequestJobFactory::AddInterceptor(Interceptor* interceptor) {
- DCHECK(CalledOnValidThread());
- CHECK(interceptor);
-
- interceptors_.push_back(interceptor);
-}
-
-URLRequestJob* URLRequestJobFactory::MaybeCreateJobWithInterceptor(
- URLRequest* request) const {
- DCHECK(CalledOnValidThread());
- URLRequestJob* job = NULL;
-
- if (!(request->load_flags() & LOAD_DISABLE_INTERCEPT)) {
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- job = (*i)->MaybeIntercept(request);
- if (job)
- return job;
- }
- }
- return NULL;
-}
-
-URLRequestJob* URLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
- const std::string& scheme,
- URLRequest* request) const {
- DCHECK(CalledOnValidThread());
- ProtocolHandlerMap::const_iterator it = protocol_handler_map_.find(scheme);
- if (it == protocol_handler_map_.end())
- return NULL;
- return it->second->MaybeCreateJob(request);
-}
-
-URLRequestJob* URLRequestJobFactory::MaybeInterceptRedirect(
- const GURL& location,
- URLRequest* request) const {
- DCHECK(CalledOnValidThread());
- URLRequestJob* job = NULL;
-
- if (!(request->load_flags() & LOAD_DISABLE_INTERCEPT)) {
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- job = (*i)->MaybeInterceptRedirect(location, request);
- if (job)
- return job;
- }
- }
- return NULL;
-}
-
-URLRequestJob* URLRequestJobFactory::MaybeInterceptResponse(
- URLRequest* request) const {
- DCHECK(CalledOnValidThread());
- URLRequestJob* job = NULL;
-
- if (!(request->load_flags() & LOAD_DISABLE_INTERCEPT)) {
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- job = (*i)->MaybeInterceptResponse(request);
- if (job)
- return job;
- }
- }
- return NULL;
-}
-
-bool URLRequestJobFactory::IsHandledProtocol(const std::string& scheme) const {
- DCHECK(CalledOnValidThread());
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- if ((*i)->WillHandleProtocol(scheme))
- return true;
- }
- return ContainsKey(protocol_handler_map_, scheme) ||
- URLRequestJobManager::GetInstance()->SupportsScheme(scheme);
-}
-
-bool URLRequestJobFactory::IsHandledURL(const GURL& url) const {
- if (!url.is_valid()) {
- // We handle error cases.
- return true;
- }
- return IsHandledProtocol(url.scheme());
-}
+URLRequestJobFactory::~URLRequestJobFactory() {}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698