chrome/browser/shell_integration_win.cc - Issue 10836247: Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_win.cc

Issue 10836247: Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adress comments about shell_util interface Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/first_run/first_run_win.cc ('K') | « chrome/browser/profiles/profile_shortcut_manager_win.cc ('k') | chrome/installer/setup/install.h » ('j') | chrome/installer/setup/install.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/shell_integration_win.cc

diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc

index 34e8d3e79737ba20b23027b7739d81e1a387200c..fe34868bc706c43859f428c264309159668a7a39 100644

--- a/chrome/browser/shell_integration_win.cc

+++ b/chrome/browser/shell_integration_win.cc

@@ -608,7 +608,8 @@ FilePath ShellIntegration::GetStartMenuShortcut(const FilePath& chrome_exe) {

continue;

}

- shortcut = shortcut.Append(shortcut_name).Append(shortcut_name + L".lnk");

+ shortcut = shortcut.Append(shortcut_name).Append(shortcut_name +

+ installer::kLnkExt);

if (file_util::PathExists(shortcut))

return shortcut;

}