Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 10836247: Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: adress comments about shell_util interface Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run_win.cc » ('j') | chrome/browser/first_run/first_run_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 8a5295b0f141d4b313669ae395c3dcc76adcc195..09a7c8d0f813123dd8a567545041e595a2d8425b 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -129,13 +129,14 @@ int DoUninstallTasks(bool chrome_still_running) {
// We want to remove user level shortcuts and we only care about the ones
// created by us and not by the installer so |alternate| is false.
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
- if (!ShellUtil::RemoveChromeDesktopShortcut(
- dist, ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_NO_OPTIONS)) {
+ if (!ShellUtil::RemoveChromeShortcut(
+ ShellUtil::SHORTCUT_DESKTOP, dist, ShellUtil::CURRENT_USER, NULL)) {
VLOG(1) << "Failed to delete desktop shortcut.";
}
// TODO(rlp): Cleanup profiles shortcuts.
- if (!ShellUtil::RemoveChromeQuickLaunchShortcut(dist,
- ShellUtil::CURRENT_USER)) {
+ if (!ShellUtil::RemoveChromeShortcut(
+ ShellUtil::SHORTCUT_QUICK_LAUNCH, dist, ShellUtil::CURRENT_USER,
+ NULL)) {
VLOG(1) << "Failed to delete quick launch shortcut.";
}
}
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run_win.cc » ('j') | chrome/browser/first_run/first_run_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698