chrome/installer/setup/install_worker.cc - Issue 10836247: Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 10836247: Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: respect microsoft's definition of correct C++ Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install_worker.cc

diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc

index b320f1cd15395b5ed40144f2c229d80d6ca0b71a..73b252e7c612a725b66f0558191b17e978acc120 100644

--- a/chrome/installer/setup/install_worker.cc

+++ b/chrome/installer/setup/install_worker.cc

@@ -256,7 +256,7 @@ void AddDeleteUninstallShortcutsForMSIWorkItems(

uninstall_link = uninstall_link.Append(

product.distribution()->GetAppShortCutName());

uninstall_link = uninstall_link.Append(

- product.distribution()->GetUninstallLinkName() + L".lnk");

+ product.distribution()->GetUninstallLinkName() + installer::kLnkExt);

VLOG(1) << "Deleting old uninstall shortcut (if present): "

<< uninstall_link.value();

WorkItem* delete_link = work_item_list->AddDeleteTreeWorkItem(

« no previous file with comments | « chrome/installer/setup/install_unittest.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »