Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe…

chrome/browser/chrome_browser_main_win.cc

Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 8a5295b0f141d4b313669ae395c3dcc76adcc195..fd092b5a7988a2afaea50a1b82c3fb4756e30974 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -129,13 +129,14 @@ int DoUninstallTasks(bool chrome_still_running) {
     // We want to remove user level shortcuts and we only care about the ones
     // created by us and not by the installer so |alternate| is false.
     BrowserDistribution* dist = BrowserDistribution::GetDistribution();
-    if (!ShellUtil::RemoveChromeDesktopShortcut(
-            dist, ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_NO_OPTIONS)) {
+    ShellUtil::ChromeShortcutProperties default_properties;

[robertshield, 2012/10/02 13:08:04]

This is slightly less readable than the previous code. Before, it was explicit
that we were working on user-level shortcuts, now it isn't unless other code has
been read and understood.

Suggest getting rid of the 0-param constructor for ChromeShortcutProperties and
instead adding a constructor that takes system/user level as a parameter.

[gab, 2012/10/03 15:14:59]

Done (and added ShellChange instead of "bool system_level" as an argument
throughout the remainder of the interface changes).

+    if (!ShellUtil::RemoveChromeShortcut(
+            ShellUtil::SHORTCUT_DESKTOP, dist, default_properties)) {
       VLOG(1) << "Failed to delete desktop shortcut.";
     }
     // TODO(rlp): Cleanup profiles shortcuts.
-    if (!ShellUtil::RemoveChromeQuickLaunchShortcut(dist,
-                                                    ShellUtil::CURRENT_USER)) {
+    if (!ShellUtil::RemoveChromeShortcut(
+            ShellUtil::SHORTCUT_QUICK_LAUNCH, dist, default_properties)) {
       VLOG(1) << "Failed to delete quick launch shortcut.";
     }
   }