Refactor ShellUtil shortcut code -- single multi-purpose methods as opposed to many slighlty diffe…

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 254 matching lines @@
 // We remove all start screen secondary tiles by removing the folder Windows
 // uses to store this installation's tiles.
 void DeleteChromeShortcuts(const InstallerState& installer_state,
                            const Product& product,
                            const string16& chrome_exe) {
   if (!product.is_chrome()) {
     VLOG(1) << __FUNCTION__ " called for non-CHROME distribution";
     return;
   }
 
-  FilePath shortcut_path;
-  if (installer_state.system_install()) {
-    PathService::Get(base::DIR_COMMON_START_MENU, &shortcut_path);
-    if (!ShellUtil::RemoveChromeDesktopShortcut(
-        product.distribution(),
-        ShellUtil::CURRENT_USER | ShellUtil::SYSTEM_LEVEL,
-        ShellUtil::SHORTCUT_NO_OPTIONS)) {
-      ShellUtil::RemoveChromeDesktopShortcut(
-          product.distribution(),
-          ShellUtil::CURRENT_USER | ShellUtil::SYSTEM_LEVEL,
-          ShellUtil::SHORTCUT_ALTERNATE);
-    }
+  BrowserDistribution* dist = product.distribution();
 
-    ShellUtil::RemoveChromeQuickLaunchShortcut(
-        product.distribution(),
-        ShellUtil::CURRENT_USER | ShellUtil::SYSTEM_LEVEL);
-  } else {
-    PathService::Get(base::DIR_START_MENU, &shortcut_path);
-    if (!ShellUtil::RemoveChromeDesktopShortcut(
-        product.distribution(),
-        ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_NO_OPTIONS)) {
-      ShellUtil::RemoveChromeDesktopShortcut(
-          product.distribution(),
-          ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_ALTERNATE);
-    }
+  ShellUtil::ChromeShortcutProperties properties;
+  // The per-user shortcut for this user, if present on a system-level install,
+  // has already been deleted in chrome_browser_main_win.cc::DoUninstallTasks().
+  properties.set_system_level(installer_state.system_install());
 
-    ShellUtil::RemoveChromeQuickLaunchShortcut(
-        product.distribution(), ShellUtil::CURRENT_USER);
+  VLOG(1) << "Deleting Desktop shortcut.";
+  if (!ShellUtil::RemoveChromeShortcut(
+          ShellUtil::SHORTCUT_DESKTOP, dist, properties)) {
+    LOG(WARNING) << "Failed to delete Desktop shortcut.";
   }
-  if (shortcut_path.empty()) {
-    LOG(ERROR) << "Failed to get location for shortcut.";
-  } else {
-    const string16 product_name(product.distribution()->GetAppShortCutName());
-    shortcut_path = shortcut_path.Append(product_name);
+  // Also try to delete the alternate desktop shortcut. It is not sufficient
+  // to do so upon failure of the above call as ERROR_FILE_NOT_FOUND on
+  // delete is considered success.
+  ShellUtil::ChromeShortcutProperties alternate_properties(properties);
+  alternate_properties.set_shortcut_name(dist->GetAlternateApplicationName());
+  if (!ShellUtil::RemoveChromeShortcut(
+          ShellUtil::SHORTCUT_DESKTOP, dist, alternate_properties)) {
+    LOG(WARNING) << "Failed to delete alternate Desktop shortcut.";
+  }
 
-    FilePath shortcut_link(shortcut_path.Append(product_name + L".lnk"));
+  VLOG(1) << "Deleting Quick Launch shortcut.";
+  if (!ShellUtil::RemoveChromeShortcut(
+          ShellUtil::SHORTCUT_QUICK_LAUNCH, dist, properties)) {
+    LOG(WARNING) << "Failed to delete Quick Launch shortcut.";
+  }
 
-    VLOG(1) << "Unpinning shortcut at " << shortcut_link.value()
-            << " from taskbar";
-    // Ignore return value: keep uninstalling if the unpin fails.
-    base::win::TaskbarUnpinShortcutLink(shortcut_link.value().c_str());
-
-    VLOG(1) << "Deleting shortcut " << shortcut_path.value();
-    if (!file_util::Delete(shortcut_path, true))
-      LOG(ERROR) << "Failed to delete folder: " << shortcut_path.value();
+  VLOG(1) << "Deleting Start Menu shortcuts.";
+  if (!ShellUtil::RemoveChromeShortcut(
+          ShellUtil::SHORTCUT_START_MENU, dist, properties)) {
+    LOG(WARNING) << "Failed to delete Start Menu shortcuts.";
   }
 
   ShellUtil::RemoveChromeStartScreenShortcuts(product.distribution(),
                                               chrome_exe);
 }
 
 bool ScheduleParentAndGrandparentForDeletion(const FilePath& path) {
   FilePath parent_dir = path.DirName();
   bool ret = ScheduleFileSystemEntityForDeletion(parent_dir.value().c_str());
   if (!ret) {
@@ skipping 945 matching lines @@
 
   // Try and delete the preserved local state once the post-install
   // operations are complete.
   if (!backup_state_file.empty())
     file_util::Delete(backup_state_file, false);
 
   return ret;
 }
 
 }  // namespace installer