[cros] Hide user pods on Login screen while images are loading.

[cros] Hide user pods on Login screen while images are loading.


BUG=142036
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151682

[ygorshenin1, 2012-08-14 14:39:27]

lgtm

http://codereview.chromium.org/10836238/diff/1004/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/user_pod_row.js (right):

http://codereview.chromium.org/10836238/diff/1004/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/user_pod_row.js:644:
$('pod-row').classList.remove('images-loading');
$('pod-row') -> this ?

[Ivan Korotkov, 2012-08-14 15:00:02]

http://codereview.chromium.org/10836238/diff/1004/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/user_pod_row.js (right):

http://codereview.chromium.org/10836238/diff/1004/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/user_pod_row.js:644:
$('pod-row').classList.remove('images-loading');
On 2012/08/14 14:39:27, ygorshenin1 wrote:
> $('pod-row') -> this ?

It's not |this| in a timer callback and I guess saving |this| to a variable and
using it later isn't much better than using $*).

[Nikita (slow), 2012-08-15 05:03:26]

lgtm

[commit-bot: I haz the power, 2012-08-15 09:28:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10836238/1004

[commit-bot: I haz the power, 2012-08-15 10:26:48]

Try job failure for 10836238-1004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...