Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 10836206: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added includes for Android Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index f763bcfae6d4c64339faa106aa4a71ba6b4fea68..d845ce4fc685fc8cef2541a94e6f2b3664921d63 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -41,6 +41,7 @@
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_error_job.h"
+#include "net/url_request/url_request_job_factory.h"
#include "net/url_request/url_request_redirect_job.h"
#include "net/url_request/url_request_throttler_header_adapter.h"
#include "net/url_request/url_request_throttler_manager.h"
@@ -1024,8 +1025,10 @@ bool URLRequestHttpJob::IsSafeRedirect(const GURL& location) {
// restrict redirects to externally handled protocols. Our consumer would
// need to take care of those.
- if (!URLRequest::IsHandledURL(location))
+ if (!(URLRequest::IsHandledURL(location) ||
+ request_->context()->job_factory()->IsHandledURL(location))) {
mmenke 2012/08/24 14:23:45 nit: Suggest !URLRequest::IsHandledURL(location)
Zulkarnainmegat42 2017/07/21 06:59:53 On 2012/08/24 14:23:45, mmenke wrote: > <font><fon
return true;
+ }
static const char* kSafeSchemes[] = {
"http",

Powered by Google App Engine
This is Rietveld 408576698