Obfuscated Gaia ID fetcher

chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/event_names.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/token_service.h"
+#include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/common/extensions/api/experimental_push_messaging.h"
 #include "content/public/browser/browser_thread.h"
 #include "googleurl/src/gurl.h"
+#include "chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h"
+
+using content::BrowserThread;
 
 namespace extensions {
 
 namespace glue = extensions::api::experimental_push_messaging;
 
 PushMessagingEventRouter::PushMessagingEventRouter(Profile* profile)
     : profile_(profile) {
 }
 
 PushMessagingEventRouter::~PushMessagingEventRouter() {}
@@ skipping 11 matching lines @@
 
   scoped_ptr<base::ListValue> args(glue::OnMessage::Create(message));
   profile_->GetExtensionEventRouter()->DispatchEventToExtension(
       extension_id,
       event_names::kOnPushMessage,
       args.Pass(),
       profile_,
       GURL());
 }
 
+PushMessagingGetChannelIdFunction::PushMessagingGetChannelIdFunction() {}
+
+PushMessagingGetChannelIdFunction::~PushMessagingGetChannelIdFunction() {}
+
+bool PushMessagingGetChannelIdFunction::RunImpl() {
+  // Start the async fetch of the GAIA ID.
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  net::URLRequestContextGetter* context = profile()->GetRequestContext();
+  TokenService* token_service = TokenServiceFactory::GetForProfile(profile());
+  const std::string& refresh_token =
+      token_service->GetOAuth2LoginRefreshToken();
+  fetcher_.reset(new ObfuscatedGaiaIdFetcher(context, this, refresh_token));
+
+  // Balanced in ReportResult()
+  AddRef();
+
+  fetcher_->Start();
+
+  // Will finish asynchronously.
+  return true;
+}
+
+void PushMessagingGetChannelIdFunction::ReportResult(
+    const std::string& gaia_id, long status) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  // Unpack the status and GaiaId parameters, and use it to build the
+  // channel ID here.
+  std::string channel_id(gaia_id);
+  if (!gaia_id.empty()) {
+    channel_id += ".";
+    channel_id += extension_id();
+  } else if (status != 0) {

[dcheng, 2012/08/20 22:52:22]

That means if gaia_id is empty and status is zero we signal success right?

It seems like we should either have:
if (status == 0) {
  DCHECK(!gaia_id.empty());
  // Set channel ID to non-empty value
} else {
  // Signal failure.
}

or

if (!gaia_id.empty()) {
  // Do stuff
} else {
  DCHECK(status != 0);
}

[Pete Williamson, 2012/08/20 23:19:28]

!= was supposed to be ==, changed.

+    status = GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS;
+  }
+
+  // TODO(petewil): It may be a good idea to further
+  // obfuscate the channel ID to prevent the user's obfuscated GAIA ID
+  // from being readily obtained.  Security review will tell us if we need to.
+
+  // Create a ChannelId results object and set the fields.
+  glue::ChannelIdResult result;
+  result.channel_id = channel_id;
+  result.status = status;
+  results_ = glue::GetChannelId::Results::Create(result);
+  SendResponse(true);
+
+  // Balanced in RunImpl
+  Release();
+}
+
+void PushMessagingGetChannelIdFunction::OnObfuscatedGaiaIdFetchSuccess(
+    const std::string& gaia_id) {
+  ReportResult(gaia_id, 0);
+}
+
+void PushMessagingGetChannelIdFunction::OnObfuscatedGaiaIdFetchFailure(
+      const GoogleServiceAuthError& error) {
+  ReportResult(std::string(), error.state());
+}
+
 }  // namespace extensions