Move VideoDecoder initialization into VideoRendererBase.

webkit/media/filter_helpers.cc

Index: webkit/media/filter_helpers.cc
diff --git a/webkit/media/filter_helpers.cc b/webkit/media/filter_helpers.cc
index 1b2642285e014f90aa7f96c7a7508386d04f94ef..c4c7f7e9990b2729428a68c2506f7bce29c463e3 100644
--- a/webkit/media/filter_helpers.cc
+++ b/webkit/media/filter_helpers.cc
@@ -33,7 +33,7 @@ static void AddDefaultDecodersToCollection(
                      base::Unretained(message_loop_factory),
                      "VideoDecoderThread"),
           decryptor);
-  filter_collection->AddVideoDecoder(ffmpeg_video_decoder);
+  filter_collection->GetVideoDecoders()->push_back(ffmpeg_video_decoder);
 }
 
 bool BuildMediaStreamCollection(const WebKit::WebURL& url,
@@ -48,16 +48,13 @@ bool BuildMediaStreamCollection(const WebKit::WebURL& url,
   if (!video_decoder)
     return false;
 
+  // Remove all other decoders and just use the MediaStream one.
   // Remove any "traditional" decoders (e.g. GpuVideoDecoder) from the

[scherkus (not reviewing), 2012/08/14 22:00:24]

is this comment duplicated?

[acolwell GONE FROM CHROMIUM, 2012/08/15 21:36:57]

Done.

   // collection.
   // NOTE: http://crbug.com/110800 is about replacing this ad-hockery with
   // something more designed.
-  scoped_refptr<media::VideoDecoder> old_videodecoder;
-  do {
-    filter_collection->SelectVideoDecoder(&old_videodecoder);
-  } while (old_videodecoder);
-
-  filter_collection->AddVideoDecoder(video_decoder);
+  filter_collection->GetVideoDecoders()->clear();
+  filter_collection->GetVideoDecoders()->push_back(video_decoder);
 
   filter_collection->SetDemuxer(new media::DummyDemuxer(true, false));