Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2928)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: bleeding_edge/dart/tools/generate_projects.py

Issue 10836101: Update gyp, keep VS 2008 default for Windows builds. (Closed) Base URL: http://dart.googlecode.com/svn/branches/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | bleeding_edge/dart/tools/gyp_dart.py » ('j') | bleeding_edge/dart/tools/gyp_dart.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bleeding_edge/dart/tools/generate_projects.py
===================================================================
--- bleeding_edge/dart/tools/generate_projects.py (revision 10270)
+++ bleeding_edge/dart/tools/generate_projects.py (working copy)
@@ -68,6 +68,13 @@
# sources are. Otherwise, Xcode won't show sources correctly.
args += ['--toplevel-dir', project_src]
Emily Fortuna 2012/08/06 17:04:08 nit: extra whitespace?
+
+ # On Win32 default to Visual Studio 2008 if no version is specified.
+
Emily Fortuna 2012/08/06 17:04:08 extra whitespace?
+ if sys.platform == 'win32':
+ if not os.environ.get('GYP_MSVS_VERSION'):
+ args.extend(['-G', 'msvs_version=2008'])
+
# Change into the dart directory as we want the project to be rooted here.
# Also, GYP is very sensitive to exacly from where it is being run.
os.chdir(dart_src)
« no previous file with comments | « no previous file | bleeding_edge/dart/tools/gyp_dart.py » ('j') | bleeding_edge/dart/tools/gyp_dart.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698