Update gyp, keep VS 2008 default for Windows builds.

Update gyp, keep VS 2008 default for Windows builds.

Use the environment variable GYP_MSVS_VERSION to override
the default.

all.deps/DEPS now calls tools/gyp_dart.py to generate
the build files. (Previously it called gyp directly.)

tools/gyp_dart.py adds the logic to make VS 2008 the
default build file format on Win32 systems.

The same logic was added to tools/generate_projects.py
which is called by all-deps/DEPS to generate build files
for dart vm sub-projects. These sub-project build files
aren't used in official builds, but apparenlty are used
by some engineers. I don't know how many of those engineers
are building on Windows, but we might as well keep the
two build systems compatible.
Committed: https://code.google.com/p/dart/source/detail?r=10299

[Emily Fortuna, 2012-08-06 17:04:08]

lgtm, with comments. 

For future reference, Jack, hit the "publish+mail comments" link after you
specify reviewers. This will send an email out to all of us, and in my
particular case, match a filter that to ensure I reply to the email quickly. :-)

http://codereview.chromium.org/10836101/diff/1/bleeding_edge/dart/tools/gener...
File bleeding_edge/dart/tools/generate_projects.py (right):

http://codereview.chromium.org/10836101/diff/1/bleeding_edge/dart/tools/gener...
bleeding_edge/dart/tools/generate_projects.py:70: 
nit: extra whitespace?

http://codereview.chromium.org/10836101/diff/1/bleeding_edge/dart/tools/gener...
bleeding_edge/dart/tools/generate_projects.py:73: 
extra whitespace?

http://codereview.chromium.org/10836101/diff/1/bleeding_edge/dart/tools/gyp_d...
File bleeding_edge/dart/tools/gyp_dart.py (right):

http://codereview.chromium.org/10836101/diff/1/bleeding_edge/dart/tools/gyp_d...
bleeding_edge/dart/tools/gyp_dart.py:24: 
nit: remove extra line

[jackpal, 2012-08-06 18:43:22]

Please review this change to update gyp while keeping dart building on Visual
Studio 2008.

[Emily Fortuna, 2012-08-06 18:44:14]

lgtm!

[ahe, 2012-08-06 19:00:15]

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
File bleeding_edge/dart/tools/gyp_dart.py (right):

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
bleeding_edge/dart/tools/gyp_dart.py:7: # This script is wrapper for Dart that
adds some support for how GYP
Please follow this style guide:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html

I'm noticing these problems:

* Indent by four.

* Use doc strings.

* function_name, not FunctionName.

* No main method.

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
bleeding_edge/dart/tools/gyp_dart.py:15: process = subprocess.Popen(args)
I think you need to call process.communicate here.

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
bleeding_edge/dart/tools/gyp_dart.py:20: args = ['python', 
"dart/third_party/gyp/gyp", "--depth=dart",
Please be consistent with ' and ".

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/deps/all.deps...
File bleeding_edge/deps/all.deps/DEPS (right):

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/deps/all.deps...
bleeding_edge/deps/all.deps/DEPS:54: # A change to a .gyp, .gypi, or to GYP
itself should run the generator.
What purpose does this comment serve?

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/deps/all.deps...
bleeding_edge/deps/all.deps/DEPS:56: "action": ["python",
"dart/tools/gyp_dart.py"],
I would like to have a TODO to get rid of this when we switch to VS2010.

[Emily Fortuna, 2012-08-06 19:36:32]

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
File bleeding_edge/dart/tools/gyp_dart.py (right):

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
bleeding_edge/dart/tools/gyp_dart.py:7: # This script is wrapper for Dart that
adds some support for how GYP
On 2012/08/06 19:00:15, ahe wrote:
> Please follow this style guide:
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
> 
> I'm noticing these problems:
> 
> * Indent by four.
> 
> * Use doc strings.
> 
> * function_name, not FunctionName.
> 
> * No main method.

I support using function_name as well, but just to be clear we have a mix of the
Internal Google Python styling and the external google python styling guide that
you linked to in our repo. See:
http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tools...
vs 
http://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tools...

Line 21 is the indent by four/line up with the opening bracket issue.

+1 doc strings.

http://codereview.chromium.org/10836101/diff/5001/bleeding_edge/dart/tools/gy...
bleeding_edge/dart/tools/gyp_dart.py:15: process = subprocess.Popen(args)
On 2012/08/06 19:00:15, ahe wrote:
> I think you need to call process.communicate here.

Only needed if he's PIPEing input or output:
http://docs.python.org/library/subprocess#subprocess.Popen.wait
which he isn't.

[Ivan Posva, 2012-08-07 05:15:00]

DBC -ip

https://chromiumcodereview.appspot.com/10836101/diff/5001/bleeding_edge/dart/...
File bleeding_edge/dart/tools/gyp_dart.py (right):

https://chromiumcodereview.appspot.com/10836101/diff/5001/bleeding_edge/dart/...
bleeding_edge/dart/tools/gyp_dart.py:1: #!/usr/bin/env python
I am wondering why this file is really needed. We already have the
generate_projects.py file which seems to do everything that is being done here
as well as taking care of running "gclient runhooks" when called from within the
generated Makefiles on Linux. These two files should be consolidated.