Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6511)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Issue 10836099: Support for promo_type. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review feedback Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
===================================================================
--- chrome/browser/ui/webui/ntp/new_tab_page_handler.cc (revision 150023)
+++ chrome/browser/ui/webui/ntp/new_tab_page_handler.cc (working copy)
@@ -63,15 +63,16 @@
}
void NewTabPageHandler::HandleCloseNotificationPromo(const ListValue* args) {
- NotificationPromo notification_promo(Profile::FromWebUI(web_ui()));
- notification_promo.HandleClosed();
+ NotificationPromo::HandleClosed(Profile::FromWebUI(web_ui()),
+ NotificationPromo::NTP_NOTIFICATION_PROMO);
Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
}
void NewTabPageHandler::HandleNotificationPromoViewed(const ListValue* args) {
- NotificationPromo notification_promo(Profile::FromWebUI(web_ui()));
- if (notification_promo.HandleViewed())
+ if (NotificationPromo::HandleViewed(Profile::FromWebUI(web_ui()),
+ NotificationPromo::NTP_NOTIFICATION_PROMO)) {
Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
+ }
}
void NewTabPageHandler::HandlePageSelected(const ListValue* args) {
« no previous file with comments | « no previous file | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698