Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 10836082: Change the UI font on CrOS to Noto Sans UI from 'Chrome Droid Sans'. (Closed)

Created:
8 years, 4 months ago by jungshik at Google
Modified:
8 years, 4 months ago
Reviewers:
Daniel Erat, sky, Evan Stade
CC:
chromium-reviews, finnur+watch_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Change the UI font on CrOS to Noto Sans UI from 'Chrome Droid Sans'. This will go after 'Noto Sans UI' is checked into ChromeOS. See https://gerrit.chromium.org/gerrit/#/c/29087/1 for the corresponding CrOS change. Bug=131515 Test=The UI (both 'native' and web ui) uses Noto Sans UI. For English UI, it's exactly the same as Chrome Droid Sans. If you try Vietnamese UI, there will be no more ransom note effect because Noto Sans UI covers all the Latin letters used in Vietnamese while Chrome Droid Sans does not and leads to a ransom note effect (some characters from Chrome Droid Sans while others coming from other fonts). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150605

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M chrome/app/resources/locale_settings_cros.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_am.xtb View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb View 1 chunk +3 lines, -3 lines 1 comment Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_hi.xtb View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_th.xtb View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/image_burner.html View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/resources/file_manager/css/video_player.css View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/resources/gesture_config.css View 1 chunk +1 line, -1 line 1 comment Download
M ui/base/strings/app_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ar.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_hi.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ja.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ko.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_th.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_zh-CN.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_zh-TW.xtb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jungshik at Google
8 years, 4 months ago (2012-08-02 23:06:37 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/10836082/diff/2001/chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb File chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb (right): http://codereview.chromium.org/10836082/diff/2001/chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb#newcode8 chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb:8: gtk-font-name="Noto Sans UI,Droid Arabic Naskh,sans-serif, 10" IDS_LOCALE_GTKRC isn't ...
8 years, 4 months ago (2012-08-02 23:22:25 UTC) #2
Evan Stade
http://codereview.chromium.org/10836082/diff/2001/chrome/browser/resources/chromeos/image_burner.html File chrome/browser/resources/chromeos/image_burner.html (right): http://codereview.chromium.org/10836082/diff/2001/chrome/browser/resources/chromeos/image_burner.html#newcode89 chrome/browser/resources/chromeos/image_burner.html:89: font-family: 'Noto Sans UI', 'Droid Sans Fallback', sans-serif; this ...
8 years, 4 months ago (2012-08-02 23:42:53 UTC) #3
jungshik at Google
> this should be using the same mechanism as all the other webui pages > ...
8 years, 4 months ago (2012-08-02 23:51:23 UTC) #4
Evan Stade
ok then lgtm :)
8 years, 4 months ago (2012-08-03 01:19:36 UTC) #5
jungshik at Google
I didn't land it sooner because I was alarmed by a font weight change. I ...
8 years, 4 months ago (2012-08-08 17:05:29 UTC) #6
sky
LGTM - but you need to address other reviewers comments
8 years, 4 months ago (2012-08-08 17:14:16 UTC) #7
jungshik at Google
8 years, 4 months ago (2012-08-08 19:13:43 UTC) #8
On 2012/08/02 23:22:25, Daniel Erat wrote:
> lgtm
> 
>
http://codereview.chromium.org/10836082/diff/2001/chrome/app/resources/platfo...
> File chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb
> (right):
> 
>
http://codereview.chromium.org/10836082/diff/2001/chrome/app/resources/platfo...
> chrome/app/resources/platform_locale_settings/locale_settings_cros_ar.xtb:8:
> gtk-font-name="Noto Sans UI,Droid Arabic Naskh,sans-serif, 10"
> IDS_LOCALE_GTKRC isn't used anywhere as far as I can tell (which is a relief,
> since we don't link against GTK).  Do you mind deleting this?  Putting it in a
> separate change is fine if that's easier.

Yeah, I noticed that, too. I thought we kept them on purpose (for test
builds/comparison with the default non-GTK builds, etc)  even though we don't
rely on GTK any more in ChromeOS.  I'll remove them in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698