Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10836051: Introduce RemoveIBusEngineService. (Closed)

Created:
8 years, 4 months ago by Seigo Nonaka
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@ibus_module_revise
Visibility:
Public.

Description

Introduce RemoveIBusEngineService. BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149574

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chromeos/dbus/dbus_thread_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
8 years, 4 months ago (2012-08-01 14:46:40 UTC) #1
satorux1
LGTM with a nit http://codereview.chromium.org/10836051/diff/1/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): http://codereview.chromium.org/10836051/diff/1/chromeos/dbus/dbus_thread_manager.cc#newcode362 chromeos/dbus/dbus_thread_manager.cc:362: ibus_engine_services_.end()) { might want to ...
8 years, 4 months ago (2012-08-01 19:54:20 UTC) #2
Seigo Nonaka
http://codereview.chromium.org/10836051/diff/1/chromeos/dbus/dbus_thread_manager.cc File chromeos/dbus/dbus_thread_manager.cc (right): http://codereview.chromium.org/10836051/diff/1/chromeos/dbus/dbus_thread_manager.cc#newcode362 chromeos/dbus/dbus_thread_manager.cc:362: ibus_engine_services_.end()) { Yes! done. On 2012/08/01 19:54:20, satorux1 wrote: ...
8 years, 4 months ago (2012-08-02 03:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10836051/3002
8 years, 4 months ago (2012-08-02 03:15:04 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 04:43:27 UTC) #5 
Change committed as 149574

Powered by Google App Engine
This is Rietveld 408576698