Issue 10836047: Revise IBus related DBus module.

Issue 10836047: Revise IBus related DBus module. (Closed)

Created:
8 years, 4 months ago by Seigo Nonaka

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revise IBus related DBus module. - IBusEngineFactoryService takes the ownership of engine_id - CreateEngine handler mapping. - Make IBusEngineFactoryService::CreateEngine asynchronous, and introduce asynchronous unittest. BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149579

Patch Set 1 : CL for review #

Patch Set 2 : Fix style nits #

Total comments: 4

Patch Set 3 : Style fix #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -33 lines)			Patch
M	chromeos/dbus/ibus/ibus_engine_factory_service.h	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_factory_service.cc	View	1	6 chunks	+31 lines, -14 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc	View	1 2	5 chunks	+81 lines, -10 lines	0 comments	Download
M	chromeos/dbus/ibus/mock_ibus_engine_factory_service.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	chromeos/dbus/ibus/mock_ibus_engine_factory_service.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

satorux1

- Introduce RemoveIBusEngineService into DBusThreadManager. This patch in the patch description is wrong? LGTM with ...

8 years, 4 months ago (2012-08-01 19:52:44 UTC) #2

Seigo Nonaka

Opps, thanks. I separated the cl from this. http://codereview.chromium.org/10836047/diff/10003/chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc File chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc (right): http://codereview.chromium.org/10836047/diff/10003/chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc#newcode27 chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc:27: : ...

8 years, 4 months ago (2012-08-02 04:11:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10836047/1017

8 years, 4 months ago (2012-08-02 04:12:16 UTC) #4

Change committed as 149579

Expand Messages | Collapse Messages