Allow offset for secondary display position in chrome://settings/display.

chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/chromeos/display_options_handler.h"
 
 #include <string>
 
 #include "ash/display/display_controller.h"
 #include "ash/display/output_configurator_animation.h"
@@ skipping 112 matching lines @@
     // So here just uses 'Display 1' or 'Display 2' for their names.
     // TODO(mukai,oshima): support vendor/model names and use it.
     js_display->SetString("name", base::StringPrintf(
         "Display %d", static_cast<int>(i) + 1));
     displays.Set(i, js_display);
   }
 
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
   base::FundamentalValue layout(
       pref_service->GetInteger(prefs::kSecondaryDisplayLayout));
+  base::FundamentalValue offset(
+      pref_service->GetInteger(prefs::kSecondaryDisplayOffset));
 
   web_ui()->CallJavascriptFunction(
       "options.DisplayOptions.setDisplayInfo",
-      mirroring, displays, layout);
+      mirroring, displays, layout, offset);
 }
 
 void DisplayOptionsHandler::FadeOutForMirroringFinished(bool is_mirroring) {
   // We use 'PRIMARY_ONLY' for non-mirroring state for now.
   // TODO(mukai): fix this and support multiple display modes.
   chromeos::OutputState new_state =
       is_mirroring ? STATE_DUAL_MIRROR : STATE_DUAL_PRIMARY_ONLY;
   ash::Shell::GetInstance()->output_configurator()->SetDisplayMode(new_state);
   SendDisplayInfo();
   // Not necessary to start fade-in animation.  OutputConfigurator will do that.
 }
 
-void DisplayOptionsHandler::FadeOutForDisplayLayoutFinished(int layout) {
+void DisplayOptionsHandler::FadeOutForDisplayLayoutFinished(
+    int layout, int offset) {
   PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
   pref_service->SetInteger(prefs::kSecondaryDisplayLayout, layout);
+  pref_service->SetInteger(prefs::kSecondaryDisplayOffset, offset);
   SendDisplayInfo();
   ash::Shell::GetInstance()->output_configurator_animation()->
       StartFadeInAnimation();
 }
 
 void DisplayOptionsHandler::HandleDisplayInfo(
     const base::ListValue* unused_args) {
   SendDisplayInfo();
 }
 
 void DisplayOptionsHandler::HandleMirroring(const base::ListValue* args) {
   DCHECK(!args->empty());
   bool is_mirroring = false;
   args->GetBoolean(0, &is_mirroring);
   ash::Shell::GetInstance()->output_configurator_animation()->
       StartFadeOutAnimation(base::Bind(
           &DisplayOptionsHandler::FadeOutForMirroringFinished,
           base::Unretained(this),
           is_mirroring));
 }
 
 void DisplayOptionsHandler::HandleDisplayLayout(const base::ListValue* args) {
   double layout = -1;
-  if (!args->GetDouble(0, &layout)) {
+  double offset = -1;
+  if (!args->GetDouble(0, &layout) || !args->GetDouble(1, &offset)) {
     LOG(ERROR) << "Invalid parameter";
     return;

[James Hawkins, 2012/08/11 17:37:42]

When does this happen?

[Jun Mukai, 2012/08/13 05:33:25]

Good point.  Added "SendDisplayInfo" to refresh the JS page status.

   }
   DCHECK_LE(DisplayController::TOP, layout);
   DCHECK_GE(DisplayController::LEFT, layout);
   ash::Shell::GetInstance()->output_configurator_animation()->
       StartFadeOutAnimation(base::Bind(
           &DisplayOptionsHandler::FadeOutForDisplayLayoutFinished,
           base::Unretained(this),
-          static_cast<int>(layout)));
+          static_cast<int>(layout),
+          static_cast<int>(offset)));
 }
 
 }  // namespace options2
 }  // namespace chromeos