Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10836038: Call CDMWrapper from PpapiDecryptor. (Closed)

Created:
8 years, 4 months ago by xhwang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Call CDMWrapper from PpapiDecryptor. This CL is for testing purpose only. No need to review. This CL is based on http://codereview.chromium.org/10545036/#ps78002 (Patch Set 25). Now that PpapiDecryptor::GenerateKeyRequest will call into the CDMWrapper and KeyMessage is called from the plugin into the PluginInstance. With this, we don't need to hack from WebMediaPlayerImpl anymore. To run the test: src/out/Debug/chrome --enable-video-track --enable-media-source --enable-encrypted-media --no-sandbox --register-pepper-plugins="src/out/Debug/lib/libppapi_example_content_decryptor.so;application/x-ppapi-content-encryption" --vmodule=pipeline*=1,proxy*=3,aes*=3,ppapi_de*=3 BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Passing callbacks. #

Patch Set 3 : Add PP_DecryptionBuffer_Dev and update Decrypt() PPP call. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -128 lines) Patch
A ppapi/api/dev/pp_decryption_buffer_dev.idl View 1 2 1 chunk +59 lines, -0 lines 3 comments Download
M ppapi/api/dev/ppb_content_decryptor_dev.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/dev/ppp_content_decryptor_dev.idl View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A ppapi/c/dev/pp_decryption_buffer_dev.h View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
M ppapi/c/dev/ppb_content_decryptor_dev.h View 1 2 4 chunks +21 lines, -24 lines 0 comments Download
M ppapi/c/dev/ppp_content_decryptor_dev.h View 1 2 3 chunks +14 lines, -16 lines 0 comments Download
M ppapi/cpp/dev/content_decryptor_dev.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/cpp/dev/content_decryptor_dev.cc View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M ppapi/examples/content_decryptor/content_decryptor.cc View 1 2 9 chunks +45 lines, -28 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/ppb_content_decryptor_thunk.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/media/crypto/key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/crypto/ppapi_decryptor.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M webkit/media/crypto/ppapi_decryptor.cc View 1 2 6 chunks +59 lines, -14 lines 1 comment Download
M webkit/plugins/ppapi/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 5 chunks +15 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 14 chunks +88 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
8 years, 4 months ago (2012-07-31 23:41:57 UTC) #1
xhwang
On 2012/07/31 23:41:57, xhwang wrote: +dmichael as this CL can help understand what we want ...
8 years, 4 months ago (2012-08-01 21:35:23 UTC) #2
xhwang
http://codereview.chromium.org/10836038/diff/5001/ppapi/api/dev/pp_decryption_buffer_dev.idl File ppapi/api/dev/pp_decryption_buffer_dev.idl (right): http://codereview.chromium.org/10836038/diff/5001/ppapi/api/dev/pp_decryption_buffer_dev.idl#newcode19 ppapi/api/dev/pp_decryption_buffer_dev.idl:19: struct PP_DecryptionBuffer_Dev { dmichael@: this is what I talked ...
8 years, 4 months ago (2012-08-07 00:53:48 UTC) #3
dmichael (off chromium)
It looks like you're still debugging, and this is all mixed up with tomfinegan's CL, ...
8 years, 4 months ago (2012-08-09 16:24:52 UTC) #4
xhwang
8 years, 4 months ago (2012-08-21 21:01:35 UTC) #5
This CL was experimental and now is obsolete. It will be replaced by a series of
updated CLs.

Powered by Google App Engine
This is Rietveld 408576698