Remove Instant v1 API.

chrome/common/render_messages.h

Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index 41f6110ad24220d8f6de74bee92012a998f64807..51094f663541478a86bdd1a49e4f17e00aba75a7 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -269,19 +269,15 @@ IPC_MESSAGE_ROUTED3(ChromeViewMsg_HandleMessageFromExternalHost,
 IPC_MESSAGE_ROUTED4(ChromeViewMsg_SearchBoxChange,
                     string16 /* value */,
                     bool /* verbatim */,
-                    int /* selection_start */,
-                    int /* selection_end */)
-IPC_MESSAGE_ROUTED2(ChromeViewMsg_SearchBoxSubmit,
-                    string16 /* value */,
-                    bool /* verbatim */)
-IPC_MESSAGE_ROUTED0(ChromeViewMsg_SearchBoxCancel)
+                    size_t /* selection_start */,
+                    size_t /* selection_end */)
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_SearchBoxSubmit,
+                    string16 /* value */)
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_SearchBoxCancel,
+                    string16 /* value */)
 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SearchBoxResize,
                     gfx::Rect /* search_box_bounds */)
-IPC_MESSAGE_ROUTED4(ChromeViewMsg_DetermineIfPageSupportsInstant,
-                    string16 /* value*/,
-                    bool /* verbatim */,
-                    int /* selection_start */,
-                    int /* selection_end */)
+IPC_MESSAGE_ROUTED0(ChromeViewMsg_DetermineIfPageSupportsInstant)
 
 // Toggles visual muting of the render view area. This is on when a constrained
 // window is showing.
@@ -604,14 +600,17 @@ IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_FocusedEditableNodeTouched)
 
 // Suggest results -----------------------------------------------------------
 
+// Sent by the Instant preview to populate the omnibox with query suggestions.
 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_SetSuggestions,
-                    int32 /* page_id */,
-                    std::vector<std::string> /* suggestions */,
-                    InstantCompleteBehavior)
+                    int /* page_id */,

[Jered, 2012/07/31 22:36:02]

Why int rather than int32?

[sreeram, 2012/07/31 23:13:19]

The style guide (http://www.chromium.org/developers/coding-style#TOC-Types)
recommends using natural types (int) wherever possible, and only specific sized
types (int32) when communicating over an interface that demands we be sure about
the size (for example, over the network, or across binaries that may not be in
sync). Though the style guide mentions IPCs as an example of such an interface,
I think it makes sense to just use int even here in the IPC because both
renderer and browser are in sync (otherwise a helluva lotta other things will
break).

Since the page_id that the renderer gets from render_view()->GetPageId() is
declared as an int, and not int32, I made this an int.

[Jered, 2012/08/01 21:56:45]

Ah, thanks for the explanation. I see both styles in use in this file.

On 2012/07/31 23:13:19, sreeram wrote:

+                    std::vector<string16> /* suggestions */,
+                    InstantCompleteBehavior /* behavior */)
 
+// Sent by the Instant preview indicating whether the page supports the Instant
+// API or not (http://dev.chromium.org/searchbox).
 IPC_MESSAGE_ROUTED2(ChromeViewHostMsg_InstantSupportDetermined,
-                    int32 /* page_id */,
-                    bool  /* result */)
+                    int /* page_id */,
+                    bool /* result */)
 
 // The currently displayed PDF has an unsupported feature.
 IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_PDFHasUnsupportedFeature)