Piping for audio encoding.

remoting/base/audio_capture_data.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_BASE_AUDIO_CAPTURE_DATA_H_
+#define REMOTING_BASE_AUDIO_CAPTURE_DATA_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "remoting/proto/audio.pb.h"
+
+namespace remoting {
+
+class AudioCaptureData {

[Sergey Ulanov, 2012/07/31 20:00:18]

add comments to explain what this is for.

[Sergey Ulanov, 2012/07/31 20:00:18]

Do we really need this class at all? Can we just use AudioPacket for both
compressed and uncompressed data - we already have fields to specify encoding
there

[kxing, 2012/07/31 22:11:44]

Done.

[kxing, 2012/07/31 22:11:44]

Done.

+ public:
+  AudioCaptureData();
+  ~AudioCaptureData();
+
+  const std::string& data() const { return data_; }
+  void set_data(std::string data) { data_.assign(data); }

[Sergey Ulanov, 2012/07/31 20:00:18]

use const reference for the argument. Might be better to provide "std::string*
mutable_data()" that returns pointer to data_

[kxing, 2012/07/31 22:11:44]

Done.

+
+  AudioPacket::SamplingRate sampling_rate() const { return sampling_rate_; }
+  void set_sampling_rate(AudioPacket::SamplingRate sampling_rate) {
+    sampling_rate_ = sampling_rate;
+  }
+
+ private:
+  std::string data_;
+  AudioPacket::SamplingRate sampling_rate_;
+
+  DISALLOW_COPY_AND_ASSIGN(AudioCaptureData);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_BASE_AUDIO_CAPTURE_DATA_H_