Change Set.add to return a boolean indicating success.

Change Set.add to return a boolean indicating success.

BUG=http://dartbug.com/3546

[floitsch, 2012-08-01 17:18:02]

LGTM.

[floitsch, 2012-08-01 17:18:42]

On 2012/08/01 17:18:02, floitsch wrote:
> LGTM.
Although I'm concerned of the fact that Set.add is now twice as slow.

[dominich, 2012-08-01 17:25:06]

On 2012/08/01 17:18:42, floitsch wrote:
> On 2012/08/01 17:18:02, floitsch wrote:
> > LGTM.
> Although I'm concerned of the fact that Set.add is now twice as slow.

I had the same concern - if this was C++ i'd use find/insert to avoid the double
lookup. I can't see anything in the HashSetImplementation to allow me to avoid
that. It might be reasonable to change putIfAbsent to return a boolean instead
of the value, or to add a new method to the base class that does the addIfAbsent
and returns if the add succeeded.

[kevmoo-old, 2013-10-07 16:20:22]

This CL is dead, no?

[Lasse Reichstein Nielsen, 2013-10-08 12:26:24]

Seems dead. HashSet has been completely reimplemented twice since it was
current.

[kevmoo-old, 2013-10-08 12:28:11]

On 2013/10/08 12:26:24, Lasse Reichstein Nielsen wrote:
> Seems dead. HashSet has been completely reimplemented twice since it was
> current.

While we're on the subject: https://codereview.chromium.org/26280002/