gdata: Periodic refresh should be active for file lists loaded from cache.

chrome/browser/chromeos/gdata/gdata_file_system.cc

Index: chrome/browser/chromeos/gdata/gdata_file_system.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.cc b/chrome/browser/chromeos/gdata/gdata_file_system.cc
index dbac872e1e02f01cbcb98b8a5e338196cd80d7bd..25cc670ba94694f7e7913f74c0875f22019e3671 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.cc
@@ -830,7 +830,7 @@ void GDataFileSystem::Initialize() {
 void GDataFileSystem::CheckForUpdates() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ContentOrigin initial_origin = directory_service_->origin();
-  if (initial_origin == FROM_SERVER) {
+  if (initial_origin != REFRESHING) {

[satorux1, 2012/07/30 16:18:26]

looks dangerous. "origin" has been a source of nasty issues...

Is it safe to check updates when the origin is INITIALIZING?

What state do you want to add in addition to FROM_SERVER? Maybe it's better to
do

  if (initial_origin == FROM_SERVER ||
      initial_origin == XXXXX) {


BTW, I wasn't clear for me why you need to change this for the other change
http://codereview.chromium.org/10835031/ to work. Could you explain?

     directory_service_->set_origin(REFRESHING);
     ReloadFeedFromServerIfNeeded(
         initial_origin,