Allow the cursor to warp even when a window is dragged

ash/display/display_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/display_controller.h"
 
 #include "ash/ash_switches.h"
 #include "ash/display/multi_display_manager.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
+#include "ash/wm/coordinate_conversion.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_util.h"
 #include "base/command_line.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/env.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/screen.h"
 
 namespace ash {
 namespace internal {
 
 DisplayController::DisplayController()
-    : secondary_display_layout_(RIGHT) {
+    : secondary_display_layout_(RIGHT),
+      allow_warp_during_lock_(false) {
   aura::Env::GetInstance()->display_manager()->AddObserver(this);
 }
 
 DisplayController::~DisplayController() {
   aura::Env::GetInstance()->display_manager()->RemoveObserver(this);
   // Delete all root window controllers, which deletes root window
   // from the last so that the primary root window gets deleted last.
   for (std::map<int, aura::RootWindow*>::const_reverse_iterator it =
            root_windows_.rbegin(); it != root_windows_.rend(); ++it) {
     internal::RootWindowController* controller =
@@ skipping 78 matching lines @@
 }
 
 void DisplayController::SetSecondaryDisplayLayout(
     SecondaryDisplayLayout layout) {
   secondary_display_layout_ = layout;
   UpdateDisplayBoundsForLayout();
 }
 
 bool DisplayController::WarpMouseCursorIfNecessary(
     aura::RootWindow* current_root,
-    const gfx::Point& point_in_root) {
+    const gfx::Point& point_in_root,
+    bool is_cursor_locked) {

[sky, 2012/08/03 17:07:18]

Can't DisplayController determine if the cursor is locked so that it doesn't
need to be passed in?

[Yusuke Sato, 2012/08/03 23:18:45]

Done.

+  if (is_cursor_locked && !allow_warp_during_lock_)
+    return false;
+
   if (root_windows_.size() < 2)
     return false;
 
+  // The cursor might be outside the |current_root|. Get the root window where
+  // the cursor is currently on.
+  std::pair<aura::RootWindow*, gfx::Point> actual_location =
+      wm::GetRootWindowRelativeToWindow(current_root, point_in_root);
+  current_root = actual_location.first;
+  // Don't use |point_in_root| below. Instead, use |actual_location.second|
+  // which is in |actual_location.first|'s coordinates.
+
   gfx::Rect root_bounds = current_root->bounds();
   int offset_x = 0;
   int offset_y = 0;
-  if (point_in_root.x() <= root_bounds.x()) {
-    offset_x = -1;
-  } else if (point_in_root.x() >= root_bounds.right() - 1) {
-    offset_x = 1;
-  } else if (point_in_root.y() <= root_bounds.y()) {
-    offset_y = -1;
-  } else if (point_in_root.y() >= root_bounds.bottom() - 1) {
-    offset_y = 1;
+  if (actual_location.second.x() <= root_bounds.x()) {
+    // Use -2, not -1, to avoid infinite loop of pointer warp.
+    offset_x = -2;
+  } else if (actual_location.second.x() >= root_bounds.right() - 1) {
+    offset_x = 2;
+  } else if (actual_location.second.y() <= root_bounds.y()) {
+    offset_y = -2;
+  } else if (actual_location.second.y() >= root_bounds.bottom() - 1) {
+    offset_y = 2;
   } else {
     return false;
   }
 
-  gfx::Point point_in_screen(point_in_root);
+  gfx::Point point_in_screen(actual_location.second);
   aura::client::ScreenPositionClient* screen_position_client =
       aura::client::GetScreenPositionClient(current_root);
   screen_position_client->ConvertPointToScreen(current_root,
                                                &point_in_screen);
   point_in_screen.Offset(offset_x, offset_y);
-  aura::RootWindow* dst_root = Shell::GetRootWindowAt(point_in_screen);
+  aura::RootWindow* dst_root = wm::GetRootWindowAt(point_in_screen);
   gfx::Point point_in_dst_root(point_in_screen);
 
   screen_position_client->ConvertPointFromScreen(dst_root,
                                                  &point_in_dst_root);
   if (dst_root->bounds().Contains(point_in_dst_root)) {
     DCHECK_NE(dst_root, current_root);
     dst_root->MoveCursorTo(point_in_dst_root);
     return true;
   }
   return false;
@@ skipping 89 matching lines @@
       break;
   }
   gfx::Insets insets = secondary_display->GetWorkAreaInsets();
   secondary_display->set_bounds(
       gfx::Rect(new_secondary_origin, secondary_bounds.size()));
   secondary_display->UpdateWorkAreaFromInsets(insets);
 }
 
 }  // namespace internal
 }  // namespace ash