Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 10835041: Adding OOBE high DPI assets (Closed)

Created:
8 years, 4 months ago by glotov
Modified:
8 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, pkotwicz
Visibility:
Public.

Description

Adding OOBE high DPI assets BUG=131177, 132773 TEST=manual, units Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149608

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : mixed hide and show :) #

Patch Set 4 : sync (data part comitted already) #

Patch Set 5 : #

Patch Set 6 : update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
D chrome/app/theme/default_100_percent/icon_add_user24_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/icon_add_user_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/icon_power24_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/icon_power_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/network_show_password_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/network_show_password_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/network_show_password_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/icon_add_user_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/icon_power_white.png View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 2 chunks +5 lines, -4 lines 2 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.css View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
glotov
Hi!
8 years, 4 months ago (2012-07-30 19:19:53 UTC) #1
Nikita (slow)
cc: pkotwicz
8 years, 4 months ago (2012-07-30 21:01:43 UTC) #2
Nikita (slow)
linux_chromeos trybot failed with grit.exception.FileNotFound: The resource file was not found. : Tried app/theme/default_{200,100}_percent/network_hide_password.png while ...
8 years, 4 months ago (2012-07-30 22:25:28 UTC) #3
Nikita (slow)
lgtm
8 years, 4 months ago (2012-07-31 05:01:06 UTC) #4
glotov
Ben, need your owner lgtm. Nikita, trybots went red on gclient phase because I touched ...
8 years, 4 months ago (2012-07-31 07:33:42 UTC) #5
Nikita (slow)
On 2012/07/31 07:33:42, glotov wrote: > Ben, need your owner lgtm. > > Nikita, trybots ...
8 years, 4 months ago (2012-07-31 07:54:57 UTC) #6
Nikita (slow)
lgtm
8 years, 4 months ago (2012-07-31 07:55:09 UTC) #7
glotov
I separated this change to part1 (commit new data only) and part2 (commit GYP and ...
8 years, 4 months ago (2012-07-31 09:15:00 UTC) #8
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:51:22 UTC) #9
Nikita (slow)
lgtm http://codereview.chromium.org/10835041/diff/21002/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): http://codereview.chromium.org/10835041/diff/21002/chrome/app/theme/theme_resources.grd#newcode281 chrome/app/theme/theme_resources.grd:281: <structure type="chrome_scaled_image" name="IDR_ICON_ADD_USER24" file="icon_add_user24.png" /> nit: Please remove ...
8 years, 4 months ago (2012-08-01 23:51:30 UTC) #10
glotov
8 years, 4 months ago (2012-08-02 11:19:10 UTC) #11
Nikita, I'll make separate change to clean it up.

Powered by Google App Engine
This is Rietveld 408576698