Issue 10834447: Scons: Drop the uses_ppapi argument from CommandSelLdrTestNacl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834447: Scons: Drop the uses_ppapi argument from CommandSelLdrTestNacl() (Closed)

Created:
8 years, 4 months ago by bradn

Modified:
8 years, 4 months ago

Reviewers:
Mark Seaborn, Nick Bray (chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Scons: Drop the uses_ppapi argument from CommandSelLdrTestNacl() The two tests using uses_ppapi (to force running against the irt) don't need to. Instead they just need ${NONIRT_LIBS} linked in. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957 TEST=None R=mseaborn@chromium.org,ncbray@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9544

Patch Set 1 : initial #

Total comments: 3

Patch Set 2 : add nonirt_libs #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
M	SConstruct	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/manifest_file/nacl.scons	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/nameservice/nacl.scons	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nick Bray (chromium)

http://codereview.chromium.org/10834447/diff/8002/SConstruct File SConstruct (right): http://codereview.chromium.org/10834447/diff/8002/SConstruct#newcode1511 SConstruct:1511: sel_ldr_flags += ['-B', nacl_env.GetIrtNexe()] Does anyone else use this ...

8 years, 4 months ago (2012-08-22 22:24:13 UTC) #2

Mark Seaborn

8 years, 4 months ago (2012-08-23 18:42:44 UTC) #4

LGTM.  BTW, I made the first line of the commit message more descriptive.

Expand Messages | Collapse Messages