chrome/browser/sync/profile_sync_service_preference_unittest.cc - Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restore expectations in DTMImpl unittest + Treat observer_ as const Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_password_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_session_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_preference_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_preference_unittest.cc b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

index 1de3d45ff881437d96af200b1aa00417ac2acf2d..a5db283f17b062450f3cdc77befa4d22a92399e2 100644

--- a/chrome/browser/sync/profile_sync_service_preference_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

@@ -133,7 +133,7 @@ class ProfileSyncServicePreferenceTest

EXPECT_CALL(*factory, GetSyncableServiceForType(syncer::PREFERENCES)).

WillOnce(Return(pref_sync_service_->AsWeakPtr()));

- EXPECT_CALL(*factory, CreateDataTypeManager(_, _)).

+ EXPECT_CALL(*factory, CreateDataTypeManager(_, _, _)).

WillOnce(ReturnNewDataTypeManager());

dtc_ = new UIDataTypeController(syncer::PREFERENCES,

factory,