chrome/browser/sync/profile_sync_components_factory_impl.h - Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restore expectations in DTMImpl unittest + Treat observer_ as const Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory.h ('k') | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl.h

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.h b/chrome/browser/sync/profile_sync_components_factory_impl.h

index 862b3c22b02ad1a6e2b8fd2039763ee199dac67f..1ec34d1873f5735549e35ff8cc2de6ec6144a650 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.h

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.h

@@ -29,7 +29,8 @@ class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory {

virtual browser_sync::DataTypeManager* CreateDataTypeManager(

browser_sync::SyncBackendHost* backend,

- const browser_sync::DataTypeController::TypeMap* controllers) OVERRIDE;

+ const browser_sync::DataTypeController::TypeMap* controllers,

+ browser_sync::DataTypeManagerObserver* observer) OVERRIDE;

virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor(

ProfileSyncService* profile_sync_service,