chrome/browser/sync/test_profile_sync_service.cc - Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test_profile_sync_service.cc

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/profile_sync_service.cc ('K') | « chrome/browser/sync/test_profile_sync_service.h ('k') | chrome/browser/ui/webui/ntp/foreign_session_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test_profile_sync_service.cc

diff --git a/chrome/browser/sync/test_profile_sync_service.cc b/chrome/browser/sync/test_profile_sync_service.cc

index a51ecb6be338fea7bc320b13c07140063b5ce64a..173cc1c41860fdf1a0657c1cba73cc61a7a6a0b1 100644

--- a/chrome/browser/sync/test_profile_sync_service.cc

+++ b/chrome/browser/sync/test_profile_sync_service.cc

@@ -208,15 +208,10 @@ void TestProfileSyncService::OnBackendInitialized(

}

-void TestProfileSyncService::Observe(

- int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) {

- ProfileSyncService::Observe(type, source, details);

- if (type == chrome::NOTIFICATION_SYNC_CONFIGURE_DONE &&

- !synchronous_sync_configuration_) {

+void TestProfileSyncService::OnConfigureDone() {

+ ProfileSyncService::OnConfigureDone();

+ if (!synchronous_sync_configuration_)

MessageLoop::current()->Quit();

- }

}

UserShare* TestProfileSyncService::GetUserShare() const {