Add histograms for network activity, and total/cumulative

chrome/browser/net/cache_stats.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_CACHE_STATS_H_
 #define CHROME_BROWSER_NET_CACHE_STATS_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 26 matching lines @@
   std::size_t operator()(const net::URLRequestContext* value) const {
     return reinterpret_cast<std::size_t>(value);
   }
 };
 }
 
 #endif
 
 namespace chrome_browser_net {
 
 // This class collects UMA stats about cache performance.

[rvargas (doing something else), 2012/08/15 22:36:50]

This is now stale. And the class name is outdated also... and the file name.

[tburkard, 2012/08/15 23:00:47]

What's a good new name?  CacheNetworkStats?  PageCacheNetworkStats? 
LoadTimeStats?

[rvargas (doing something else), 2012/08/16 01:18:40]

LoadTimeStats or NetStats sound good to me.

[tburkard, 2012/08/16 22:37:43]

Done.

 class CacheStats {
  public:
   enum TabEvent {
     SPINNER_START,
     SPINNER_STOP
   };
+  enum RequestStatus {
+    REQUEST_STATUS_CACHE_WAIT,
+    REQUEST_STATUS_NETWORK_WAIT,
+    REQUEST_STATUS_ACTIVE,
+    REQUEST_STATUS_NONE,
+    REQUEST_STATUS_MAX
+  };
+  enum HistogramType {
+    HISTOGRAM_FINAL_AGGREGATE,
+    HISTOGRAM_FINAL_CUMULATIVE,
+    HISTOGRAM_FINAL_CUMULATIVE_PERCENTAGE,
+    HISTOGRAM_INTERMEDIATE_AGGREGATE,
+    HISTOGRAM_INTERMEDIATE_CUMULATIVE,
+    HISTOGRAM_INTERMEDIATE_CUMULATIVE_PERCENTAGE,
+    HISTOGRAM_MAX
+  };
+
   CacheStats();
   ~CacheStats();
 
-  void OnCacheWaitStateChange(const net::URLRequest& request,
-                              net::NetworkDelegate::CacheWaitState state);
+  void OnRequestWaitStateChange(const net::URLRequest& request,
+                                net::NetworkDelegate::RequestWaitState state);
   void OnTabEvent(std::pair<int, int> render_view_id, TabEvent event);
   void RegisterURLRequestContext(const net::URLRequestContext* context,
                                  ChromeURLRequestContext::ContextType type);
   void UnregisterURLRequestContext(const net::URLRequestContext* context);
 
  private:
   struct TabLoadStats;
   // A map mapping a renderer's process id and route id to a TabLoadStats,
   // representing that renderer's load statistics.
   typedef std::map<std::pair<int, int>, TabLoadStats*> TabLoadStatsMap;
 
   // Gets TabLoadStats for a given RenderView.
   TabLoadStats* GetTabLoadStats(std::pair<int, int> render_view_id);
   // Deletes TabLoadStats no longer needed for a render view.
   void RemoveTabLoadStats(std::pair<int, int> render_view_id);
   // Sets a timer for a given tab to collect stats.  |timer_index| indicates
   // how many times stats have been collected since the navigation has started
   // for this tab.
   void ScheduleTimer(TabLoadStats* stats);
   // The callback when a timer fires to collect stats again.
   void TimerCallback(TabLoadStats* stats);
-  // Helper function to put the current set of cache statistics into an UMA
-  // histogram.
-  void RecordCacheFractionHistogram(base::TimeDelta elapsed,
-                                    base::TimeDelta cache_time,
-                                    bool is_load_done,
-                                    int timer_index);
+  // Helper function to put the current set of statistics into UMA histograms.
+  void RecordHistograms(base::TimeDelta elapsed,
+                        TabLoadStats* stats,
+                        bool is_load_done);
 
   TabLoadStatsMap tab_load_stats_;
-  std::vector<base::Histogram*> final_histograms_;
-  std::vector<base::Histogram*> intermediate_histograms_;
+  std::vector<base::Histogram*> histograms_[REQUEST_STATUS_MAX][HISTOGRAM_MAX];
   base::hash_set<const net::URLRequestContext*> main_request_contexts_;
 
   DISALLOW_COPY_AND_ASSIGN(CacheStats);
 };
 
 // A WebContentsObserver watching all tabs, notifying CacheStats
 // whenever the spinner starts or stops for a given tab, and when a renderer
 // is no longer used.
 class CacheStatsTabHelper : public content::WebContentsObserver {
  public:
@@ skipping 18 matching lines @@
 
   CacheStats* cache_stats_;
   bool is_otr_profile_;
 
   DISALLOW_COPY_AND_ASSIGN(CacheStatsTabHelper);
 };
 
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_CACHE_STATS_H_